<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107321/">http://git.reviewboard.kde.org/r/107321/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 1f5edb207af5b5cb8665d2dd817ae379c210e307 by David Edmundson to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On November 14th, 2012, 5:50 a.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Nov. 14, 2012, 5:50 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use AccountsComboBox in AddContactDialog and JoinChatRoomDialog
This removes incorrect usages of ContactModel to create lists of accounts in common internals,
as well as removing some duplicate code.
This patch also fixes the JoinChatRoomDialog not updating as accounts become online/offline.
Note this breaks the API for all people using AddContactDialog (ktp-contact-list and ktp-presence-applet)
(for the last time!)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Widgets/add-contact-dialog.h <span style="color: grey">(cd4b66e9aabd045be6bf2185f6d262de4639e9eb)</span></li>
<li>KTp/Widgets/add-contact-dialog.cpp <span style="color: grey">(ddc26bdaa1e2f95f5cbd28633abaa95f5a0b8738)</span></li>
<li>KTp/Widgets/add-contact-dialog.ui <span style="color: grey">(616fc71782e2721ca78e15df46778b93a7717432)</span></li>
<li>KTp/Widgets/join-chat-room-dialog.cpp <span style="color: grey">(34905396d2d3c9795d1c1b81fdd4725e6d1b88ff)</span></li>
<li>KTp/Widgets/join-chat-room-dialog.ui <span style="color: grey">(2d077c46a42b7f922d497bc3ba07efe421b542de)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107321/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>