<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107266/">http://git.reviewboard.kde.org/r/107266/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 12th, 2012, 10:40 a.m., <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">...after fixing Dominik's comment. I think possible errors while removing accounts should be handled/displayed.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There's not a lot of handling to do. The account is only removed from the list when we get the AccountRemoved signal. If this op fails, we don't need to handle anything as nothing changes.
As for displaying, the only possible error is:
http://telepathy.freedesktop.org/spec/Account.html#Method:Remove
which will never come up in our system or potentially if MC control crashed and we get no reply from the system. What error could we display which would be useful to a user?</pre>
<br />
<p>- David</p>
<br />
<p>On November 13th, 2012, 2:32 a.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Nov. 13, 2012, 2:32 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port to AccountsListModel</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(ee82fd0f82b3c158f1bef670b08120ef22974b6c)</span></li>
<li>src/account-item.h <span style="color: grey">(a2fee834c7e0e65931fa82c437be754e95ec333c)</span></li>
<li>src/account-item.cpp <span style="color: grey">(8efc78fb135b7cf29b750fcfeb11c1b94eaa44a6)</span></li>
<li>src/accounts-list-delegate.cpp <span style="color: grey">(a2333290639588b6d6c09e3ae149083001da45d2)</span></li>
<li>src/accounts-list-model.h <span style="color: grey">(10786674ab0d5a7bada9f6b3e3be9acd0aa235cd)</span></li>
<li>src/accounts-list-model.cpp <span style="color: grey">(4a015fa517c625099f4fb05da3572e53b243d2ad)</span></li>
<li>src/edit-account-dialog.h <span style="color: grey">(d1c370d44dd0edd0f90726243a6e6f5dc38dbf48)</span></li>
<li>src/edit-account-dialog.cpp <span style="color: grey">(5982e06bd8fe75d9972d38e91f4ae0c6d65a4a75)</span></li>
<li>src/kcm-telepathy-accounts.h <span style="color: grey">(29629ebce869ac35882acce925551cd9dc49910a)</span></li>
<li>src/kcm-telepathy-accounts.cpp <span style="color: grey">(6389a67410ab7a81c5378c216251747952853e5e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107266/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>