<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107298/">http://git.reviewboard.kde.org/r/107298/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 12th, 2012, 9:16 a.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1) There's way more than that needed. You must still have some old headers about.
2) There's a review here: https://git.reviewboard.kde.org/r/107266/ which fixes everything.
It's not merged because I haven't had a "ship it!" on it
Thanks for getting involved though!</pre>
</blockquote>
<p>On November 12th, 2012, 10:27 a.m., <b>Diego Casella</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yep, I noticed now that on other repos are affected indeed (i.e. ktp-contact-list,ktp-text-ui and ktp-presence-applet) :)
Anyways, instead of leaving 5 repos in a broken state, wouldn't be more appropriate to put all these changes in separate branches and, once approved, push'em all into master?
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ktp-contact-list, and text-ui had fixes pushed at the same time.
Presence applet is not affected.
Only Accounts-KCM is affected. (and for a while contact-applet because I forgot about it)
>wouldn't be more appropriate to put all these changes in separate branches and, once approved, push'em all into master?
That was the plan.
All work was done in separate branches. The ML was notified in advance. I did start pushing before I got a ship it on the accounts-kcm, which was wrong of me. I hadn't expected to get any review comments.
Then I had to leave the office.. didn't get internet again till I read this.
</pre>
<br />
<p>- David</p>
<br />
<p>On November 12th, 2012, 9:13 a.m., Diego Casella wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Diego Casella.</div>
<p style="color: grey;"><i>Updated Nov. 12, 2012, 9:13 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems like someone forgot to update an include statement due to some refactoring, and therefore the build process broke :)
It's a very simple, one liner, patch which addresses that issue.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested against b9338a30fc3fcc41bab10fe79cb0fbaddaf57b98 and builds fine :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/accounts-list-delegate.cpp <span style="color: grey">(a233329)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107298/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>