<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107295/">http://git.reviewboard.kde.org/r/107295/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't fully understand the point, there are no other handlers you would want to use.
However, as per usual, your code is really neat and tidy. so ship it.
Watch out for your "QString& foo" which should apparently be "QString &foo". There's a few cases in your cpp.</pre>
<br />
<p>- David</p>
<br />
<p>On November 12th, 2012, 4:20 p.m., Daniele Elmo Domenichelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Daniele Elmo Domenichelli.</div>
<p style="color: grey;"><i>Updated Nov. 12, 2012, 4:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Together with https://git.reviewboard.kde.org/r/107169 , I would like to have methods to set and get preferred handlers, so here it is, documentation included.
In future, when we have the .desktop magic working, I would like to add methods to retrieve available handlers for one channel type in order to have some interface where we can configure them, for now I suggest we start using preferredHandlerForXXX everywhere.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Run this test, works as expected both reading and writing, but I'm too lazy to write proper unit tests, since we don't have them yet in ktp-common-internals (yes, we definitely should have them, but that's another patch)
kDebug() << KTp::Handlers::defaultHandlerForTextChat();
kDebug() << KTp::Handlers::defaultHandlerForFileTransfer();
kDebug() << KTp::Handlers::defaultHandlerForAudioVideo();
kDebug() << KTp::Handlers::defaultHandlerForDesktopSharing();
kDebug() << KTp::Handlers::preferredHandlerForTextChat();
kDebug() << KTp::Handlers::preferredHandlerForFileTransfer();
kDebug() << KTp::Handlers::preferredHandlerForAudioVideo();
kDebug() << KTp::Handlers::preferredHandlerForDesktopSharing();
kDebug() << KTp::Handlers::preferredHandlerForTextChat(QLatin1String("A"));
kDebug() << KTp::Handlers::preferredHandlerForFileTransfer(QLatin1String("B"));
kDebug() << KTp::Handlers::preferredHandlerForAudioVideo(QLatin1String("C"));
kDebug() << KTp::Handlers::preferredHandlerForDesktopSharing(QLatin1String("D"));
KTp::Handlers::setPreferredHandlerForTextChat(QLatin1String("E"));
KTp::Handlers::setPreferredHandlerForFileTransfer(QLatin1String("F"));
KTp::Handlers::setPreferredHandlerForAudioVideo(QLatin1String("G"));
KTp::Handlers::setPreferredHandlerForDesktopSharing(QLatin1String("H"));
kDebug() << KTp::Handlers::preferredHandlerForTextChat(QLatin1String("I"));
kDebug() << KTp::Handlers::preferredHandlerForFileTransfer(QLatin1String("J"));
kDebug() << KTp::Handlers::preferredHandlerForAudioVideo(QLatin1String("K"));
kDebug() << KTp::Handlers::preferredHandlerForDesktopSharing(QLatin1String("L"));
KTp::Handlers::unsetPreferredHandlerForTextChat();
KTp::Handlers::unsetPreferredHandlerForFileTransfer();
KTp::Handlers::unsetPreferredHandlerForAudioVideo();
KTp::Handlers::unsetPreferredHandlerForDesktopSharing();
kDebug() << KTp::Handlers::preferredHandlerForTextChat();
kDebug() << KTp::Handlers::preferredHandlerForFileTransfer();
kDebug() << KTp::Handlers::preferredHandlerForAudioVideo();
kDebug() << KTp::Handlers::preferredHandlerForDesktopSharing();
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/CMakeLists.txt <span style="color: grey">(0fd12f084384c4df308707b8879e51d8b5908c69)</span></li>
<li>KTp/handlers.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/handlers.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107295/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>