<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107269/">http://git.reviewboard.kde.org/r/107269/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This looks like it works and it's lot simpler, but I'm a bit confused as to why it was the way it was before.
I want you to get a ship it! from dvratil too before you commit.</pre>
<br />
<p>- David</p>
<br />
<p>On November 9th, 2012, 10:38 p.m., Daniele Elmo Domenichelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy, David Edmundson and Dan Vrátil.</div>
<div>By Daniele Elmo Domenichelli.</div>
<p style="color: grey;"><i>Updated Nov. 9, 2012, 10:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Basically the first time that the log is loaded, processStoredEvents was called just once, all the other times it was called twice, by onLoadFinished() and by onEventsLoaded().
I'm still not convinced about the reason, perhaps a race condition between the two methods (onLoadFinished starts asyncronously when the page is loaded after initialise in onEventsLoaded), but it looks very deterministic (never happens the first time, and happens always from the second time), perhaps it is related to theme loading.
Anyway, the loadFinished signal is emitted when the page is loaded, after that initialise(headerInfo) sets the page template, therefore it is the best place to call processStoredEvents().
0.5 branch is ok?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Loaded several logs both single and multi users, works</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=309828">309828</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>logviewer/message-view.h <span style="color: grey">(0c90ded700f1d5435d96b583522432486dc51067)</span></li>
<li>logviewer/message-view.cpp <span style="color: grey">(012c3b717b4b0e06af1c77def2ab38ed6b30e1f0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107269/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>