<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107245/">http://git.reviewboard.kde.org/r/107245/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 8th, 2012, 2:57 a.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why is this in the KDED? KDED Modules should always be really really tiny. This isn't.
It doesn't need to run throughout a KDE session, and prompts when you first log in aren't a good idea either.
I strongly think we should consider what the objectives actually are, and then reconsider where this goes. </pre>
</blockquote>
<p>On November 8th, 2012, 12:46 p.m., <b>Dan Vrátil</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree that KDED module is not the best solution.
My idea was to have something like KResoure Migrator and KDED seemed like the best victim to abuse for that. We can't say "ok, let's do it on application startup", because we can't really know which KTp components users use and will start (unlike the KDED which is more or less guaranteed to run for every KTp user).
Would it be OK to have a custom small binary placed probably in common-internals, with autostart .desktop in /usr/share/autostart? After first run the application would disable itself:
KSharedConfigPtr config = KGlobal::config();
KConfigGroup group( config, "Startup" );
group.writeEntry( "EnableAutostart", false );
At least this is how kaddressbookmigrator does it [0]. I can't see any code to check whether the migrator should start when EnableAutostart is FALSE, so I assume KDE does this automagically when iterating through .desktop files in /usr/share/autostart.
[0] http://quickgit.kde.org/index.php?p=kdepim-runtime.git&a=blob&f=migration%2Fkaddressbook%2Fkaddressbookmigrator.cpp</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The only place the logs are useful is the log viewer so we could do it on loading that.</pre>
<br />
<p>- David</p>
<br />
<p>On November 7th, 2012, 2:24 p.m., Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated Nov. 7, 2012, 2:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a dialog to the ktp-kded module.
The dialog will run only once - it will check whether there are any Kopete logs that match your current KTp accounts and show you a list where you can select which logs you want to import.
After that it won't bother you never ever again.
For me the KDED module starts automatically on every login, but Martin told me that it's depends on some things and that it might not start every time. Please test this too.
I'd like to ask someone who actually speaks English to review the labels and messages. I suck at this...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Logged in, got dialog, succesfully imported all logs, logged out, logged in, no dialog.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(024ad76)</span></li>
<li>logs-import-dialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>logs-import-dialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>telepathy-module.h <span style="color: grey">(748437d)</span></li>
<li>telepathy-module.cpp <span style="color: grey">(7ab13b2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107245/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>