<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105926/">http://git.reviewboard.kde.org/r/105926/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 82a26bbaddfd898374b039038e77702575cbe1e7 by David Edmundson to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On August 8th, 2012, 1:40 p.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Aug. 8, 2012, 1:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Async wallet usage. Updated to compile with latest common-internals
Also tidied up some rather mental/legacy code when removing accounts from the model. Hopefully fixes the crashes when removing accounts that we've been seeing.
The wallet stuff is still a bit messy, the API wasn't really suitable for async usage. When I ported it I tried to do it in the least destructive way which in retrospect turned out to be a really bad idea.
I've decided how I'm going to fix it all in the future (based on the WalletUtil class here) but for getting password data too. But I don't want to redo that all now.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Created an account, edited it, removed it.
No problems. Would appreciate more testing once merged though.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(ee82fd0)</span></li>
<li>src/account-item.h <span style="color: grey">(aba7e0e)</span></li>
<li>src/account-item.cpp <span style="color: grey">(0cac63f)</span></li>
<li>src/accounts-list-model.h <span style="color: grey">(1791e67)</span></li>
<li>src/accounts-list-model.cpp <span style="color: grey">(c7837bc)</span></li>
<li>src/add-account-assistant.cpp <span style="color: grey">(880b423)</span></li>
<li>src/edit-account-dialog.h <span style="color: grey">(6fdf98d)</span></li>
<li>src/edit-account-dialog.cpp <span style="color: grey">(91eeccf)</span></li>
<li>src/kcm-telepathy-accounts.cpp <span style="color: grey">(ca37ad1)</span></li>
<li>src/wallet-utils.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/wallet-utils.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105926/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>