<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107243/">http://git.reviewboard.kde.org/r/107243/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit b6e0f2aa343abac8fd5be85613ed75757ebc2fae by Dan Vrátil to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On November 9th, 2012, 9:57 a.m., Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated Nov. 9, 2012, 9:57 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds KTp::LogsImporter class to Common Internals.
You just need to pass Tp::AccountPtr to it and it will try to find a matching Kopete logs, convert them to TpLogger XML format and import them.
If the output log file already exists, the importer will simply skip it. I tried to implement merging but results were quite unpredictable. Most users won't have logs of conversations with the same contact from the same day from both Kopete AND KTp anyway.
The implementation supports AIM, WLM, ICQ, Yahoo, Jabber and GaduGadu protocols. I skipped Skype since we don't support it. Other protocols are not supported by Telepathy, so no reason to import them to TpLogger.
The class is places in common-internals, because it's used from KDED and KCM (I'll post separate reviews for these).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Successfully imported my old Kopete logs and displayed them in LogViewer. However for testing purposes I recommend backuping ~/.local/share/TpLogger.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/CMakeLists.txt <span style="color: grey">(ae65dc7)</span></li>
<li>KTp/logs-importer-private.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/logs-importer-private.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/logs-importer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/logs-importer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107243/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>