<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106432/">http://git.reviewboard.kde.org/r/106432/</a>
     </td>
    </tr>
   </table>
   <br />









<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/106432/diff/2/?file=93351#file93351line147" style="color: black; font-weight: bold; text-decoration: underline;">KTp/Models/accounts-model-item.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">AccountsModelItem::~AccountsModelItem()</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">147</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span class="k">return</span> <span class="n">ContactsModel</span><span class="o">::</span><span class="n">ContactRowType</span><span class="p">;</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wow, well spotted!</pre>
</div>
<br />



<p>- David</p>


<br />
<p>On November 3rd, 2012, 7:26 a.m., David Edmundson wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>


<p style="color: grey;"><i>Updated Nov. 3, 2012, 7:26 a.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rename AccountsModel to ContactsModel as it is a model of contacts.

This is in preperation for providing a model of accounts to use in combo boxes everywhere. (this will be called AccountsModel, and would be very confusing if we don't rename this)</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updated ContactList to the rename. Everything still works.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>KTp/Models/CMakeLists.txt <span style="color: grey">(4bdff28aef93994ab88fde995952c48f126a34f2)</span></li>

 <li>KTp/Models/accounts-filter-model.cpp <span style="color: grey">(607df5492cacf96ca1f125760f51d5d900094e5e)</span></li>

 <li>KTp/Models/accounts-list-model.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Models/accounts-list-model.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Models/accounts-model-item.cpp <span style="color: grey">(12794178becf0fee635511b39d3a08726e75b64f)</span></li>

 <li>KTp/Models/accounts-model.h <span style="color: grey">(caf93faa1aa95308d722a73accea0205abc8a6b8)</span></li>

 <li>KTp/Models/accounts-model.cpp <span style="color: grey">(8233a37f62808a7ba58bfcb4471bf734ad813a93)</span></li>

 <li>KTp/Models/contact-model-item.cpp <span style="color: grey">(110299846acbc1d36b7f9e17a4849222318676c4)</span></li>

 <li>KTp/Models/contacts-model.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Models/contacts-model.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Models/groups-model-item.cpp <span style="color: grey">(d62829bba1fe2aa52d367327ea37018405f80d9a)</span></li>

 <li>KTp/Models/groups-model.h <span style="color: grey">(00e6f1a943b17dd07e54c30613e3566ba271aace)</span></li>

 <li>KTp/Models/groups-model.cpp <span style="color: grey">(f0d607d2d13261f75158a26ebe274170062db2c4)</span></li>

 <li>KTp/Models/proxy-tree-node.cpp <span style="color: grey">(fb5674bddffc5cc5d3c07662a5466d99f6b79fbb)</span></li>

 <li>KTp/Widgets/CMakeLists.txt <span style="color: grey">(708c8b0d67917ac862fed68966d7afb29e2770b7)</span></li>

 <li>KTp/Widgets/accounts-combo-box.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Widgets/accounts-combo-box.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Widgets/add-contact-dialog.h <span style="color: grey">(a32633b6a86e2aefc728ed4b7b511de0c3e8d733)</span></li>

 <li>KTp/Widgets/add-contact-dialog.cpp <span style="color: grey">(7198c126df8354bbfa5df3bdf0020e1e8cf8b4cb)</span></li>

 <li>KTp/Widgets/contact-grid-dialog.h <span style="color: grey">(2df1c21b2983643922645a1c5efddd6dfe7ae198)</span></li>

 <li>KTp/Widgets/contact-grid-dialog.cpp <span style="color: grey">(f454dee5e8b2fcca5cb663bbb762512ed3fd7c73)</span></li>

 <li>KTp/Widgets/contact-grid-widget.h <span style="color: grey">(256a09a7589d26bad2ec2e225777240993a2c67f)</span></li>

 <li>KTp/Widgets/contact-grid-widget.cpp <span style="color: grey">(eb25d7e64df9979d9922a03750155af8432de570)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106432/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>