<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107151/">http://git.reviewboard.kde.org/r/107151/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit c4ee109a419ed68a8f0c635ac0192836a9e177cd by Daniele E. Domenichelli to branch filters.</pre>
<br />
<p>- Commit</p>
<br />
<p>On October 31st, 2012, 2:38 p.m., Daniele Elmo Domenichelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Daniele Elmo Domenichelli.</div>
<p style="color: grey;"><i>Updated Oct. 31, 2012, 2:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Configure version in CMakeLists.txt instead of in main.cpp
I would like to merge this also in the stable branch even if it adds the version.h.in file, since it simplifies handling the version and avoids stupid errors ("AdiumXtra Protocol Handler" version is at the moment "0.3.60")</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ktp-text-ui --version
ktp-logviewer --version
ktp-adiumxtra-protocol-handler --version</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(1d1d72b877348ade85e4835e8e586b3c18ffc11e)</span></li>
<li>adiumxtra-protocol-handler/main.cpp <span style="color: grey">(8610008b5ba7bc5b6da13b689b05709ff9b3198e)</span></li>
<li>app/main.cpp <span style="color: grey">(e6ac76ac8fae6882226c7f2dca6f4d007b283b66)</span></li>
<li>logviewer/main.cpp <span style="color: grey">(98c5123f659e3eb71d36a4070c173fd403eb585e)</span></li>
<li>version.h.in <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107151/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>