<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107132/">http://git.reviewboard.kde.org/r/107132/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd prefer to have a separate component right away, rather then hacking it now and waiting for someone else to clean it up.
One issue I've run to: I set Renkoo as group chat theme, reopened the Settings dialog, went to the Group chat tab again and the preview was not populated (this does not happen with SimKete though). I don't know whether this is caused by the Renkoo theme, but it might indicate problem in our code (I don't have any other themes to test right now). This does not happen in the "Single chat" tab.</pre>
<br />
<p>- Dan</p>
<br />
<p>On October 30th, 2012, 4:19 p.m., Daniele Elmo Domenichelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Daniele Elmo Domenichelli.</div>
<p style="color: grey;"><i>Updated Oct. 30, 2012, 4:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a quick and dirty way to fix it, basically I duplicated the code for the single user chat and added a tabbed view.
Perhaps it could be a widget in order to avoid code duplication, but since we have just 2, I'd leave it like this for now, so that we can configure this in 0.6, and perhaps open a junior-job bug for this</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Config works, group chat works</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=295843">295843</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>config/appearance-config.ui <span style="color: grey">(7fe6ce43a952652edcca229b918283b05268b240)</span></li>
<li>lib/adium-theme-view.cpp <span style="color: grey">(24b9c3570699f64e1b751183430e4975dc6a449d)</span></li>
<li>config/appearance-config.h <span style="color: grey">(5b6c83d6ac4001f1d28b3ce1cb8e18a38e5269c5)</span></li>
<li>config/appearance-config.cpp <span style="color: grey">(7f42857998b509a03dc8168181850a7a9a2a477d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107132/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>