<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107154/">http://git.reviewboard.kde.org/r/107154/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- David</p>
<br />
<p>On October 31st, 2012, 3:19 p.m., Daniele Elmo Domenichelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy, David Edmundson and Lasath Fernando.</div>
<div>By Daniele Elmo Domenichelli.</div>
<p style="color: grey;"><i>Updated Oct. 31, 2012, 3:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">[Requires review 107151]*
Add property X-KTp-PluginInfo-Version to plugins
This property holds the ktp-text-ui plugin framework version for which the plugin is written, and allow us to switch the branch easily, without caring of removing uncompatible plugins. This also allows us to "disable" plugins if there is a problem just by bumping the version without updating it for that plugin.
I would like to merge this in stable branch, and bump version to 2 in master and to 3 in filters branch
*Not really, I could change it to do it in some other ways, but it is nicer using the version.h file and configuring it in CMakeLists.txt</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works, only the plugins with the correct version are loaded and displayed in the plugin config dialog</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(1d1d72b877348ade85e4835e8e586b3c18ffc11e)</span></li>
<li>filters/emoticons/ktptextui_message_filter_emoticons.desktop <span style="color: grey">(ee8a51c23c553e1f1f3383531d79bcef314a3226)</span></li>
<li>filters/formatting/ktptextui_message_filter_formatting.desktop <span style="color: grey">(366de49363d72d879c0b3ae5baf442a846a9ab87)</span></li>
<li>filters/images/ktptextui_message_filter_images.desktop <span style="color: grey">(6dbbe591535d3202b2be8672fd25d7c63659d183)</span></li>
<li>filters/searchexpansion/ktptextui_message_filter_searchexpansion.desktop <span style="color: grey">(8b606c522d97152ad22e1dbcbb3b79db465685de)</span></li>
<li>filters/texttospeech/ktptextui_message_filter_tts.desktop <span style="color: grey">(5e9810dc1926e3d2e76c1a0391fc07fab9e43725)</span></li>
<li>lib/ktptxtui_message_filter.desktop <span style="color: grey">(c7d045337bcfeb7c6bf5096bc8397f756298987b)</span></li>
<li>lib/plugin-config-manager.cpp <span style="color: grey">(b1a4d5b59a0a63f5b3f2a90ab81ca9a8f4e05693)</span></li>
<li>version.h.in <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107154/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>