<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107119/">http://git.reviewboard.kde.org/r/107119/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit ed8161506ea03839e2ff3db9eb7134c53535d531 by David Edmundson to branch master.</pre>
 <br />







<p>- Commit</p>


<br />
<p>On October 30th, 2012, 12:49 a.m., Daniele Elmo Domenichelli wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By Daniele Elmo Domenichelli.</div>


<p style="color: grey;"><i>Updated Oct. 30, 2012, 12:49 a.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Update build system to use latest tools and cmake stuff from tp-qt 0.9.3 and install TelepathyLoggerQt4Config.cmake and export files.

This allows to remove the FindTelepathyLoggerQt4.cmake files and to check for its version

Note: most of the changes are files just copied from tp-qt 0.9.3. The relevant files are:
- CMakeLists.txt
- TelepathyLoggerQt4/CMakeLists.txt
- TelepathyLoggerQt4/TelepathyLoggerQt4Config.cmake.in</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built and tested text-ui and log-viewer after removing FindTelepathyLogger.cmake and FindTelepathyLoggerQt4.cmake
Version check works
 - macro_optional_find_package(TelepathyLoggerQt4 0.5.1) -> found
 - macro_optional_find_package(TelepathyLoggerQt4 0.5.2) -> not found</pre>
  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=304856">304856</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>tools/qt4-types-gen.py <span style="color: grey">(1a5fef7b28937a4a364ce6895858c465c08455ff)</span></li>

 <li>tools/qt4-client-gen.py <span style="color: grey">(22223946256af4d9f8ba0040de44a92b4ae3da96)</span></li>

 <li>tools/qt4-constants-gen.py <span style="color: grey">(11c4b5eda1843fe9eccb599ca3bb939106478ec9)</span></li>

 <li>tools/qt-types-gen.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tools/qt-svc-gen.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tools/qt-constants-gen.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tools/qt-client-gen.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tools/libqtcodegen.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tools/CMakeLists.txt <span style="color: grey">(36d70a0b655f6333bbfd2a7d18b805711a2ea1f1)</span></li>

 <li>tools/libqt4codegen.py <span style="color: grey">(8cf1889808f79fb0f9c2ccfa7b7194937a55fd2d)</span></li>

 <li>cmake/modules/TpQtMacros.cmake <span style="color: grey">(PRE-CREATION)</span></li>

 <li>cmake/modules/MacroWriteBasicCMakeVersionFile.cmake <span style="color: grey">(PRE-CREATION)</span></li>

 <li>cmake/modules/TpQt4Macros.cmake <span style="color: grey">(85fb925be3fc4c1ded41fd65acd7286eca97d82c)</span></li>

 <li>TelepathyLoggerQt4/CMakeLists.txt <span style="color: grey">(ae688d3a0a95203a4fc7b51ffbbf02d06a7d7592)</span></li>

 <li>TelepathyLoggerQt4/TelepathyLoggerQt4Config.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>

 <li>cmake/modules/BasicFindPackageVersion.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>

 <li>cmake/modules/FindQt.cmake <span style="color: grey">(PRE-CREATION)</span></li>

 <li>cmake/modules/FindQt5.cmake <span style="color: grey">(PRE-CREATION)</span></li>

 <li>CMakeLists.txt <span style="color: grey">(b88e06e2a28d77400bfa5480e02cfdce34482891)</span></li>

 <li>tools/tp-qt-tests.supp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tools/tp-qt4-tests.supp <span style="color: grey">(2c0f12011d2d356416e2ab8f146eab0d738f1668)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107119/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>