<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106664/">http://git.reviewboard.kde.org/r/106664/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, I'm just not sure what you want to move to extragear...</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106664/diff/1/?file=87921#file87921line355" style="color: black; font-weight: bold; text-decoration: underline;">src/kcm-telepathy-accounts.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KCMTelepathyAccounts::onEditIdentityClicked()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">355</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">new</span> <span class="n">Tp</span><span class="o">::</span><span class="n">PendingComposite</span><span class="p">(</span><span class="n">ops</span><span class="p">,</span> <span class="n">account</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If this can end in errors, it should be connected to a slot handling the error.</pre>
</div>
<br />
<p>- Martin</p>
<br />
<p>On September 30th, 2012, 11:53 p.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Sept. 30, 2012, 11:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make AccountsModelItem private and instead expose a role of just the AccountPtr
This means AccountsItem can be private, ready for the move to extragear.
Also fixes a potential crash if the account is removed whilst editing as EditAccountDialog stores the AccountPtr which is ref counted.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/account-item.h <span style="color: grey">(a2fee834c7e0e65931fa82c437be754e95ec333c)</span></li>
<li>src/account-item.cpp <span style="color: grey">(8efc78fb135b7cf29b750fcfeb11c1b94eaa44a6)</span></li>
<li>src/accounts-list-delegate.cpp <span style="color: grey">(a2333290639588b6d6c09e3ae149083001da45d2)</span></li>
<li>src/accounts-list-model.h <span style="color: grey">(10786674ab0d5a7bada9f6b3e3be9acd0aa235cd)</span></li>
<li>src/accounts-list-model.cpp <span style="color: grey">(4a015fa517c625099f4fb05da3572e53b243d2ad)</span></li>
<li>src/edit-account-dialog.h <span style="color: grey">(08a3481b6d0566f0314d1682ef722e38862fe105)</span></li>
<li>src/edit-account-dialog.cpp <span style="color: grey">(a747242a0eba49791d60a2f986228133297012a1)</span></li>
<li>src/kcm-telepathy-accounts.cpp <span style="color: grey">(8d1f2ece4943feec257eb761cf5a803a004b60cb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106664/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>