<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106635/">http://git.reviewboard.kde.org/r/106635/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I want this committed the 0.5 branch too
Also be sure to update krunner.</pre>
<br />
<p>- David</p>
<br />
<p>On September 29th, 2012, 3:52 p.m., Dan Vratil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vratil.</div>
<p style="color: grey;"><i>Updated Sept. 29, 2012, 3:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Starting logviewer with preselected Facebook contact fails, because Facebook contacts UIDs start with "-", so KCmdLineArgs interprets it as an (invalid) argument and fails to start logviewer.
This patch changes logviewer cmd line syntax to
ktp-log-viewer accountID,contactID
i.e. passing accountID and contactID as a single argument and separating them just by comma. This assumes comma is not an allowed character within accountID and contactID, which I believe is a safe assumption.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=307577">307577</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/chat-window.cpp <span style="color: grey">(57cc33f)</span></li>
<li>logviewer/entity-view.cpp <span style="color: grey">(69c408f)</span></li>
<li>logviewer/main.cpp <span style="color: grey">(f960c2a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106635/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>