<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106575/">http://git.reviewboard.kde.org/r/106575/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 25th, 2012, 8 p.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106575/diff/1/?file=87140#file87140line1031" style="color: black; font-weight: bold; text-decoration: underline;">./chat-widget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ChatWidget::saveSpellCheckingOption(const QString &dict)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1031</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">configGroup</span><span class="p">.</span><span class="n">exists</span><span class="p">()</span> <span class="o">||</span> <span class="n">dict</span> <span class="o">!=</span> <span class="n">KGlobal</span><span class="o">::</span><span class="n">locale</span><span class="p">()</span><span class="o">-></span><span class="n">language</span><span class="p">()){</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You've got a bug here.
I talk to Martin on English (my default), I change to German.
now I change back to English.
This will not save anything as English is my default language, and I'll be still on German next time I load.
Doing an "if dict != locale()->language()" is a very good idea, but it needs an " else { removeEntry...() "
Also why bother checking the config group exists? That sounds a wrong thing to do.
</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I will change this code, deleting the user Id with the default language,as it is much better than what I thought:
Because of configGroup.exists(), the above example you gave works-had tested it-.In your case configGroup.exists() returns true (user id is already written in file) the second time you choose English, so, the statement will succeed despite of what language option you have, native or not.I thought this way to avoid writing data for a user who never configures the file at all, but writing data for anyone else that has done even one modification-without any deletion.
</pre>
<br />
<p>- Nick</p>
<br />
<p>On September 25th, 2012, 7:52 p.m., Nick Lou wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Nick Lou.</div>
<p style="color: grey;"><i>Updated Sept. 25, 2012, 7:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix for the reported Bug 291764 (Set spellchecking language per contact instead of per tab).
If a contact changes the default spellchecking option to one of his/her choice,
the new option is saved in a file as a pair, target Id and spell checking option,
where the target Id is a group and option value has a key named "language".
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested it by changing the spellchecking option of various pairs,
and then by closing and reopening their chat tabs and checking the values.
I also checked the values stored in the config file.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=291764">291764</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>../../defaults/chat-widget.h <span style="color: grey">(7d2dcf2)</span></li>
<li>../../defaults/chat-widget.cpp <span style="color: grey">(6c9c7ed)</span></li>
<li>../../defaults/chat-window.cpp <span style="color: grey">(eb1b7a0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106575/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>