<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106515/">http://git.reviewboard.kde.org/r/106515/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 900824a2f8ea5eb35a483e40498a593842bdb7ce by David Edmundson to branch kde-telepathy-0.5.</pre>
<br />
<p>- Commit</p>
<br />
<p>On September 20th, 2012, 4:38 p.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Sept. 20, 2012, 4:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Check connection manager supports protocol listed in profile. This should fix the issue of skype appearing in the list when telpeathy-haze was installed but pidgin-skype was not.
ConnectionManagers require having becomeReady() called before the list of protocols they support can be used, hence converting from a list of CMs to a hash of CmPtrs
Relevant IRC conversation about ABI breaking:
[16:53] <d_ed> gkiagia: how bad is it to break the ABI on a private library with no installed headers that no-one else uses between 0.5.0 and 0.5.1
[16:53] <d_ed> (the accounts KCM lib)
[16:53] <gkiagia> not an issue</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/KCMTelepathyAccounts/profile-list-model.cpp <span style="color: grey">(35ced7cb3e4b4959a798ac6a7a7ff7369f10bb6e)</span></li>
<li>src/KCMTelepathyAccounts/profile-list-model.h <span style="color: grey">(d133ffcffec376064264c4310e39d6e0f0f836d0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106515/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>