<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106507/">http://git.reviewboard.kde.org/r/106507/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Daniele Elmo</p>
<br />
<p>On September 19th, 2012, 4:35 p.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2012, 4:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hide presence applet if you have no accounts. We want distributions to add the presence-applet by default to the systray as it makes everything work better.
However, for people who don't use IM having an extra icon there would be annoying.
This hides the icon using Plasma item status, and makes it appear only unhide if you have an account already or add one. By hidden, I mean make it appear not in the main system tray but in the silly little pop-out arrow where hidden sys-tray icons go.
Request adding to 0.5 branch.
It doesn't check when you remove accounts (until next login), this is partly by design as it's generally bad for icons to mysteriously disappear (and partly due to laziness/wanting to keep this patch simple to add to 0.5).
For 0.6 I've heard someone suggest we should set status depending if you're online/offline. Needs discussion.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed all my accounts. Checked it was hidden on first login, and reappeared when I added an account.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/presenceapplet.h <span style="color: grey">(2de67ac1a927bac37e2adc51884dafa22da04b5c)</span></li>
<li>src/presenceapplet.cpp <span style="color: grey">(aa843c9332cb6d116837d73cbe9f58f9ad504495)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106507/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>