<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106229/">http://git.reviewboard.kde.org/r/106229/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 9th, 2012, 5:07 p.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106229/diff/1/?file=81375#file81375line252" style="color: black; font-weight: bold; text-decoration: underline;">logviewer/log-viewer.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void LogViewer::clearAccountHistory()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">252</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">logManager</span><span class="o">-></span><span class="n">clearAccountHistory</span><span class="p">(</span><span class="n">account</span><span class="p">))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's generally a bad idea to update the UI whilst deleting things.
The ideal way of doing this is you call clearAccount, and then are notified from the backend that the data has been cleared which you monitor for.
Otherwise if a remove fails, you still hide it, also if someone else clears the account you don't hide it.
However I'm not sure there's a way to do this. Think about it for a little while and see if there's a better way before committing.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unfortunately Tpl doesn't provide any "notify" API, so I wouldn't know about the log being removed. I could only think of two solutions for this:
- polling, which in general is a very bad solution
- watching the file system (like Nepomuk does) and being notified about log file/folder going missing. I think that's an extreme overkill for our little utility though, so no.
This leaves me with the current solution, which I agree with you is not an optimal solution, but I think it's good enough (for now).
Anyway, I fixed the handler to display an error message when clearing fails instead of hiding the item. As I said above, I can't effectively learn that someone else delete the log, so I can't hide the item after that. You can't do it from anywhere else in KTp though and if someone would do it from an another log viewer or would delete the log file directly from file system while running our logviewer, then from my point of view it's his/hers problem if something breaks.
</pre>
<br />
<p>- Dan</p>
<br />
<p>On August 31st, 2012, 10:53 p.m., Dan Vratil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vratil.</div>
<p style="color: grey;"><i>Updated Aug. 31, 2012, 10:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a popup menu to entity view. The menu has "Clear account history" and "Clear contact history" actions.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Successfully destroyed all my logs</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=305762">305762</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>logviewer/entity-model-item.h <span style="color: grey">(e740d25)</span></li>
<li>logviewer/entity-model-item.cpp <span style="color: grey">(c7f2249)</span></li>
<li>logviewer/entity-model.h <span style="color: grey">(205c132)</span></li>
<li>logviewer/entity-model.cpp <span style="color: grey">(cbee00a)</span></li>
<li>logviewer/log-viewer.h <span style="color: grey">(4a9e20b)</span></li>
<li>logviewer/log-viewer.cpp <span style="color: grey">(83d329c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106229/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>