<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106228/">http://git.reviewboard.kde.org/r/106228/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 1st, 2012, 4:52 a.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Awkward question. I was looking in the source code to check something, doesn't all this exist in PendingLogger?</pre>
</blockquote>
<p>On September 1st, 2012, 10:21 a.m., <b>Dan Vratil</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It does, but Tpl::PendingLogger is not part of public API and requires Tpl::Logger which is not public either. Providing the API in Tpl::LogManager (by calling Tpl::PendingLogger) seems more logical to me because clearing logs == log management and also because we can simplify some calls for users (see Tpl::LogManager::clearEntityHistory()).</pre>
</blockquote>
<p>On September 1st, 2012, 11:04 a.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, I agree your code is better.
But having two sets of code in the source that does the same thing is clearly silly. As it wasn't public before, I suggest we delete both pendinglogger and logger.
Agree?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oops, I made a mistake, the Tpl::Logger is public and exported so it cannot be removed if TPLQt4 follows KDE BC policies. OTOH KTp is most probably the only user of TPLQt4, so just bumping minimum requred version in all components for KTp 0.6 should prevent any issues that removing Tpl::Logger could cause. Your call...
If you want to keep it I'll just cancel this review request and update the other one to use Tpl::Logger directly.</pre>
<br />
<p>- Dan</p>
<br />
<p>On August 31st, 2012, 10:45 p.m., Dan Vratil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Dan Vratil.</div>
<p style="color: grey;"><i>Updated Aug. 31, 2012, 10:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add three new methods to Tpl::LogManager to invoke telepathy-logger DBus methods for clearing logs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works, be careful :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>TelepathyLoggerQt4/log-manager.h <span style="color: grey">(c245965)</span></li>
<li>TelepathyLoggerQt4/log-manager.cpp <span style="color: grey">(e6acf40)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106228/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>