<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106245/">http://git.reviewboard.kde.org/r/106245/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 27th, 2012, 10:33 p.m., <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just out of curiosity - what's the use case of having the last sent messages available on key_arrow_up press (in 1-1 chat)?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would use the history to "store" unfinished message. Typically - you are writing a (longer) message, when the other side suddenly sends you a new message. Currently you have to store the current message you are writing in clipboard. With the history you just press arrow down, which stores current text in the history and clears the editor, reply to the message and then by pressing arrow up you get the unfinished message again.
I might be also useful to re-send undelivered messages, to make a correction in a sent message or to easily spam the other party :)
My use cases are usually a bit atypical, so the above might not be a real use case of most people - in that case we could have it enabled only in MUC?</pre>
<br />
<p>- Dan</p>
<br />
<p>On August 27th, 2012, 10:19 p.m., Dan Vratil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vratil.</div>
<p style="color: grey;"><i>Updated Aug. 27, 2012, 10:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This implements navigation through history of sent messages by pressing Up and Down arrow keys like in Konversation. It's actually based on code from Konversation, I just didn't implement navigating by scrolling mouse wheel in the message editor as it's possible to have scrollbar in the message box (unlike in Konversation) and it would be extremely annoying for users if scrolling "beyond" end of the text would change the content of the message box.
I also tried populating the history of newly opened chat by a few last lines from last log, but I'm unsure about this feature. Subjectively it felt a bit confusing when I opened a new window and pressing Up key was pasting some text that appeared from "nowhere" and was not related to this session/conversation. But feel free to discuss, I can provide the code if you want to try. Alternatively we can just wait if users will ask for this functionality :)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=303648">303648</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/chat-text-edit.h <span style="color: grey">(3e2dec0)</span></li>
<li>lib/chat-text-edit.cpp <span style="color: grey">(e4ca62c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106245/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>