<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106089/">http://git.reviewboard.kde.org/r/106089/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 20th, 2012, 7:28 a.m., <b>Daniele Elmo Domenichelli</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't want to review the other patch again, so please do another branch for this...
Also remove the auto-generated files, I don't want to review them as well.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I had to edit the auto-generated files, that's why I have added them in the source code. While using the qt4_add_dbus_adaptor and qt4_add_dbus_interface the Q_SIGNALS that were defined were not according to the definition I gave, but had no parameters.
I defined my signal in the xml file as
<signal name="addInterface">
<arg name='objPath' type='s' direction='in'/>
</signal>
but the Q_SIGNAL defined in the interface and adaptor class was
Q_SIGNALS:
void addInterface();
</pre>
<br />
<p>- Puneet</p>
<br />
<p>On August 19th, 2012, 6:18 p.m., Puneet Goyal wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Puneet Goyal.</div>
<p style="color: grey;"><i>Updated Aug. 19, 2012, 6:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implemented the Object Manager Interface. Using the interface, Tabbed Kwhiteboard is also implemented.
GetManagedObjects method of the interface is not implemented yet, and the interface added signal is also having a parameter of QString only.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwhiteboard/CMakeLists.txt <span style="color: grey">(4a86efc)</span></li>
<li>kwhiteboard/ObjectManagerAdaptor.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwhiteboard/ObjectManagerAdaptor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwhiteboard/ObjectManagerInterface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwhiteboard/ObjectManagerInterface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwhiteboard/kwhiteboard-handler.cpp <span style="color: grey">(ade1218)</span></li>
<li>kwhiteboard/kwhiteboard.h <span style="color: grey">(33361c6)</span></li>
<li>kwhiteboard/kwhiteboard.cpp <span style="color: grey">(c16fd04)</span></li>
<li>kwhiteboard/kwhiteboardwidget.h <span style="color: grey">(431ccf2)</span></li>
<li>kwhiteboard/kwhiteboardwidget.cpp <span style="color: grey">(ce1b2a9)</span></li>
<li>kwhiteboard/main.cpp <span style="color: grey">(4371285)</span></li>
<li>kwhiteboard/objectManager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwhiteboard/objectManager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwhiteboard/org.kde.DBus.ObjectManager.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwhiteboard/org.kde.DBus.Peer.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwhiteboard/peer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwhiteboard/peer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106089/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>