<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106024/">http://git.reviewboard.kde.org/r/106024/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 14th, 2012, 10:26 p.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wait -
>From ContactListWidget
Q_ASSERT(contact);
QString group;
if (index.data(AccountsModel::ItemRole).canConvert<GroupsModelItem*>()) {
// contact is dropped on a group, so take it's name
group = index.data(GroupsModel::GroupNameRole).toString();
} else {
// contact is dropped on another contact, so take it's parents (group) name
group = index.parent().data(GroupsModel::GroupNameRole).toString();
}
kDebug() << contact->contact().data()->alias() << "added to group" << group;
if (!group.isEmpty()) {
Tp::PendingOperation *op = contact->contact().data()->addToGroup(group);
connect(op, SIGNAL(finished(Tp::PendingOperation*)),
this, SIGNAL(genericOperationFinished(Tp::PendingOperation*)));
}
this is checking group.isEmpty() and that group comes from GroupNameRole
so as I see it, this will now create it on the server. Which is why this patch was made in the first place.</pre>
<br />
<p>- David</p>
<br />
<p>On August 14th, 2012, 10:13 p.m., Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Aug. 14, 2012, 10:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If the contact has no groups, it is placed into "Ungrouped" group. This is done when the group name is empty. However the group still needs some id in the model to properly handle the expanded/collapsed state, ie. you can't save an empty string into config file. The AccountsModel::IdRole & GroupsModel::GroupNameRole is not used anywhere in the UI, so the user won't see this. And returning this on the model level makes sure this group is actually not created on the server.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Models/groups-model-item.cpp <span style="color: grey">(c85ffbf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106024/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>