<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105433/">http://git.reviewboard.kde.org/r/105433/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 15th, 2012, 4:51 p.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105433/diff/2/?file=72216#file72216line36" style="color: black; font-weight: bold; text-decoration: underline;">lib/message.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString Message::mainMessagePart() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">36</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_mainPart</span> <span class="o">=</span> <span class="n">message</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">36</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_mainPart</span> <span class="o">=</span> <span class="n">message</span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">trimmed</span></span><span class="p"><span class="hl">()</span>;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree with Martin we can't alter every message for the sake of one plugin.
What you can do is trim it in the filter.
KUriFilterData data(message.mainMessagePart().trimmed());
that will still pass all your test cases exactly.
Related:
- as you have this test suite, add a message with leading and trailing whitespace to make sure no plugin ever alters it.</pre>
</blockquote>
<p>On August 7th, 2012, 8:59 a.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch was committed without my comment addressed.</pre>
</blockquote>
<p>On August 7th, 2012, 11:13 p.m., <b>Lasath Fernando</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh that one. I thought I replied here but oh well, more herp derping on my part.
The justification for this is that this is already done in other places, like in MessagesModel (and HTML ignores multiple whitespaces anyway). So overall, this shouldn't change the look of how things are displayed in the chat.
I was going to remove other code that messed with whitespace as I found them.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The escape filter turns spaces into , thus making them render correctly in HTML so this /shouldn't/ be justified.
If someone has broken this, that's a bug.</pre>
<br />
<p>- David</p>
<br />
<p>On July 12th, 2012, 8:39 a.m., Lasath Fernando wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Lasath Fernando.</div>
<p style="color: grey;"><i>Updated July 12, 2012, 8:39 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Even with all the mucking around I did, I still managed to get some work done today after all :)
Okay, this filter is fairly straightforward, it takes the whole message and sticks it through KUriFiler::filterSearchUri().
I had to make a slight tweak to Message so that it ignores leading and trailing whitespace.
This does have a slight catch in that it runs after UrlFilter, so the URLs it sticks in aren't clickable. But since this is really meant for outgoing messages, I thought it wasn't a major requirement.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Passed Unit tests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/CMakeLists.txt <span style="color: grey">(4560704)</span></li>
<li>filters/searchexpansion/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/searchexpansion/ktptextui_message_filter_searchexpansion.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/searchexpansion/searchexpansion-filter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/searchexpansion/searchexpansion-filter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/message.cpp <span style="color: grey">(d0e62b4)</span></li>
<li>tests/message-processor-basic-tests.h <span style="color: grey">(35f931f)</span></li>
<li>tests/message-processor-basic-tests.cpp <span style="color: grey">(554ce1a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105433/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>