<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105733/">http://git.reviewboard.kde.org/r/105733/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 25th, 2012, 11:52 p.m., <b>George Kiagiadakis</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm afraid renaming .desktop files to .in files is going to make them untranslatable... Better check with the translators first.</pre>
</blockquote>
<p>On July 26th, 2012, 11:07 a.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well spotted!
What if I don't do the renaming? I copy the file to a different folder when I do my string replacement. The vesrion field isn't translatable anyway, so it shouldn't cause any problems.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The solution is 'ExtraDesktop.sh' - see http://lxr.kde.org/source//kde/kdesdk/kapptemplate/ExtraDesktop.sh
Basically we just add this file which prints the names of the .desktop-like files which are named differently and we're good.</pre>
<br />
<p>- Martin</p>
<br />
<p>On July 25th, 2012, 11:12 p.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated July 25, 2012, 11:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Store the KTp version in CMakeKtpVersion.txt, all references to this version then use this version number thanks to some configure_file.
When making a release this can then just be copied and pasted between repos, rather than having to hunt for everything, which should make releases easier.
If this gets the go-ahead, I'll update all other repos to follow a very similar pattern.
Note: because I edited some .desktop files it appears as massive diffs, I only edited the version line.
A lot of these desktop files need quite some fixing, but it's not related to this patch.
Note 2: I haven't done the plasmoid in this repo.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeKtpVersion.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(a5a3826)</span></li>
<li>app/main.cpp <span style="color: grey">(4c75137)</span></li>
<li>config.h.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/emoticons/CMakeLists.txt <span style="color: grey">(6ba9b27)</span></li>
<li>filters/emoticons/ktptextui_message_filter_emoticons.desktop <span style="color: grey">(7d9ee8e)</span></li>
<li>filters/emoticons/ktptextui_message_filter_emoticons.desktop.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/formatting/CMakeLists.txt <span style="color: grey">(11741f0)</span></li>
<li>filters/formatting/ktptextui_message_filter_formatting.desktop <span style="color: grey">(316b4e3)</span></li>
<li>filters/formatting/ktptextui_message_filter_formatting.desktop.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/images/CMakeLists.txt <span style="color: grey">(f09c1f4)</span></li>
<li>filters/images/ktptextui_message_filter_images.desktop <span style="color: grey">(58d03bb)</span></li>
<li>filters/images/ktptextui_message_filter_images.desktop.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>logviewer/main.cpp <span style="color: grey">(54af921)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105733/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>