<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105642/">http://git.reviewboard.kde.org/r/105642/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 22nd, 2012, 10:31 a.m., <b>George Kiagiadakis</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, let's start from the basics: Use of the review board.
1) You should not attach the .diff file. Instead, you should upload it where it says "Diff" on the new review request page.
2) Diff files must be either generated with "git diff" (if you are using git) or with "diff -uprN oldfile newfile". The current format that you uploaded is wrong.
3) You do not need to attach the whole file. The diff, if uploaded properly, is enough.
4) Review persons/groups: Just the "telepathy" group is enough.
5) Bugs field: You should enter only bug numbers there, not any words.
Regarding the diff:
1) It is incomplete, it does not show changes in the header. Since you are doing diffs manually, extract the entire tarball contents in a new directory and compare the two directories with "diff -uprN originaldir modifieddir". Git helps of course...
2) The load function is definitely not correct. At least all the connect() statements should not be executed twice, so they should only be in the constructor.
This is all for now.</pre>
</blockquote>
<p>On July 22nd, 2012, 11:44 p.m., <b>Nick Lou</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have a problem uploading the diff file.I followed all the instructions above using diff and importing all the data to a file:
diff -uprN originaldir modifieddir > file.diff
The problem is, that I can not upload it, as the upload diff option at the top right of the page gives me an error of an empty diff (The specified diff file is empty) .What to do with this one?
Thank you.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I finally uploaded it as a file, I don't know why I got that error message.</pre>
<br />
<p>- Nick</p>
<br />
<p>On July 22nd, 2012, 11:56 p.m., Nick Lou wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Nick Lou.</div>
<p style="color: grey;"><i>Updated July 22, 2012, 11:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Kde-telepathy 0.4.0, text-ui.
Bug 295106 (The reset button in kcm_ktp_chat_apparence is not working)
I fixed this bug, it seems working properly to me now.Please note that default button had the same problem, fixed that too.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On theme config settings:
1)Applying a theme.
2)Pressing default button //action: setting options to default values.
3)Pressing reset button //action:setting options to applied values
4)Repeating this procedure several times.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=295106">295106</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105642/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>