<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105571/">http://git.reviewboard.kde.org/r/105571/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 14th, 2012, 1:47 p.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105571/diff/1/?file=72665#file72665line4" style="color: black; font-weight: bold; text-decoration: underline;">filters/images/ktptextui_message_filter_images.desktop</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">3</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Comment=//TODO:.</pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Comment=//TODO:.</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think you want a comment in here (such that it appears in the plugin loader) that describes what it does</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">These are already in master. I don't think merging this patch will do any further harm...
Also, I want to go to bed soon. Can you guys discuss some nice comments with plenty of marketing hype and buzzwords on IRC/ML?</pre>
<br />
<p>- Lasath</p>
<br />
<p>On July 14th, 2012, 12:36 p.m., Lasath Fernando wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Lasath Fernando.</div>
<p style="color: grey;"><i>Updated July 14, 2012, 12:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I skimmed through BKO and I don't think there are any bugs about not being able to disable Message Filters :O
But anyway, this addresses that issue by building a KCM. There currently isn't any way of getting to it apart
from running kcmshell4 kcm_ktp_chat_messages (which only now occurred to me might be an issue).
When having to deal with only loading enabled plugins, the code in MessageProcessor started to get a little
horrific, so I split that off into a new class called PluginConfigManager. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Passes unit tests when plugins are enabled, fails when they're not.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/plugin-config-manager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/plugin-config-manager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>config/messages-config.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/emoticons/ktptextui_message_filter_emoticons.desktop <span style="color: grey">(2626102)</span></li>
<li>filters/formatting/format-filter.cpp <span style="color: grey">(b8f0b53)</span></li>
<li>filters/formatting/ktptextui_message_filter_formatting.desktop <span style="color: grey">(7dc8cb7)</span></li>
<li>filters/images/ktptextui_message_filter_images.desktop <span style="color: grey">(649f206)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(f172936)</span></li>
<li>lib/message-processor.h <span style="color: grey">(08cc386)</span></li>
<li>lib/message-processor.cpp <span style="color: grey">(926bef7)</span></li>
<li>config/kcm_ktp_chat_messages.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>config/messages-config.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>config/CMakeLists.txt <span style="color: grey">(dbe0de9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105571/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>