<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105130/">http://git.reviewboard.kde.org/r/105130/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Great patch, thanks!</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105130/diff/3/?file=70142#file70142line95" style="color: black; font-weight: bold; text-decoration: underline;">KTp/Models/accounts-filter-model.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">95</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// If filtering by presence, hide accounts with no online contacts</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It can be confusing if you don't see your connected account. At least in the accounts mode, I think the account should always be visible, even if there is no user online, but it at least gives the user indication, that he is online with that account (and in fact it shows 0/XX, so he immediately knows noone is online).
Discussed on irc, will be shipped directly.</pre>
</div>
<br />
<p>- Martin</p>
<br />
<p>On June 22nd, 2012, 10:28 a.m., Dominik Cermak wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dominik Cermak.</div>
<p style="color: grey;"><i>Updated June 22, 2012, 10:28 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried to solve it on filter model level. Here is what I've done so far, it's not finished yet but I want to show it so you can speak up if it's totally (or partly) wrong, so I don't waste time. I still have to find out what I can remove from the other code now.
Also it's not so nice to have so much in data(), so if someone has an idea how to make this more elegant, I'm open for suggestions.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now the counters work as expected.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=300956">300956</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Models/accounts-filter-model.h <span style="color: grey">(9ed824a1e9a970e33b07343ae9143734857820c8)</span></li>
<li>KTp/Models/accounts-filter-model.cpp <span style="color: grey">(c17b3359178ffceca5ae815d41008058218f3bf5)</span></li>
<li>KTp/Models/accounts-model-item.h <span style="color: grey">(11554a9624de0fb7ba2d9123ef770d090a3b952d)</span></li>
<li>KTp/Models/accounts-model-item.cpp <span style="color: grey">(1d65af3fd6d2b8b52562c7dccb63104bb026428d)</span></li>
<li>KTp/Models/accounts-model.cpp <span style="color: grey">(795a1f4615369dbb01f631e9347cf239a523899b)</span></li>
<li>KTp/Models/groups-model-item.h <span style="color: grey">(26dcb00aaf5135a578983680303080dc9e5d51bd)</span></li>
<li>KTp/Models/groups-model-item.cpp <span style="color: grey">(00dbede6e6431c9666cbb293a02c2572e8cac1a5)</span></li>
<li>KTp/Models/groups-model.cpp <span style="color: grey">(6e295ab543b712fd4075684df6cd164beae295e0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105130/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>