<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105130/">http://git.reviewboard.kde.org/r/105130/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure about one thing: In the patch as it is now (diff 3) I removed all the counting code form the two models, but that means that one have to use the filter model to get the counts. If one wants to use the AccountsModel/GroupsModel without the filter model maybe we should leave the counting code in those models, which would mean we would count twice...</pre>
<br />
<p>- Dominik</p>
<br />
<p>On June 22nd, 2012, 10:28 a.m., Dominik Cermak wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dominik Cermak.</div>
<p style="color: grey;"><i>Updated June 22, 2012, 10:28 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried to solve it on filter model level. Here is what I've done so far, it's not finished yet but I want to show it so you can speak up if it's totally (or partly) wrong, so I don't waste time. I still have to find out what I can remove from the other code now.
Also it's not so nice to have so much in data(), so if someone has an idea how to make this more elegant, I'm open for suggestions.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now the counters work as expected.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=300956">300956</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Models/accounts-filter-model.h <span style="color: grey">(9ed824a1e9a970e33b07343ae9143734857820c8)</span></li>
<li>KTp/Models/accounts-filter-model.cpp <span style="color: grey">(c17b3359178ffceca5ae815d41008058218f3bf5)</span></li>
<li>KTp/Models/accounts-model-item.h <span style="color: grey">(11554a9624de0fb7ba2d9123ef770d090a3b952d)</span></li>
<li>KTp/Models/accounts-model-item.cpp <span style="color: grey">(1d65af3fd6d2b8b52562c7dccb63104bb026428d)</span></li>
<li>KTp/Models/accounts-model.cpp <span style="color: grey">(795a1f4615369dbb01f631e9347cf239a523899b)</span></li>
<li>KTp/Models/groups-model-item.h <span style="color: grey">(26dcb00aaf5135a578983680303080dc9e5d51bd)</span></li>
<li>KTp/Models/groups-model-item.cpp <span style="color: grey">(00dbede6e6431c9666cbb293a02c2572e8cac1a5)</span></li>
<li>KTp/Models/groups-model.cpp <span style="color: grey">(6e295ab543b712fd4075684df6cd164beae295e0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105130/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>