<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104465/">http://git.reviewboard.kde.org/r/104465/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 71c322f91616c03c8bfb22cdee947d3095280ab2 by David Edmundson to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On April 2nd, 2012, 1:38 a.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated April 2, 2012, 1:38 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Approves ssh stream tubes.
Shows an indicator. Also keeps the status notifier persistent allowing the user to close the connection at any time (useful for a windowless tube, like the ssh-contact server)
It currently only handles 1 type of tube in a very non-flexible way. I shall improve on that at some point in the near future when I've worked out how best to do that. (Ideally I want to load a set of .desktop files I think, I need to talk to George K about his plans with upstream).
I figured it'd be better to get this merged than do one super huge harder to read patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(1d6f697)</span></li>
<li>src/approverdaemon.cpp <span style="color: grey">(d8239b7)</span></li>
<li>src/channelapprover.cpp <span style="color: grey">(4130a86)</span></li>
<li>src/ktpapprovermodule.cpp <span style="color: grey">(e71d5b9)</span></li>
<li>src/streamtubechannelapprover.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/streamtubechannelapprover.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104465/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>