<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105344/">http://git.reviewboard.kde.org/r/105344/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 25th, 2012, 10:35 a.m., <b>Alex Fiestas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can't tell what this patch does exactly (screenshots !) but generally across all KDE software people usually grey out entries instead of removing them.
Maybe until there is a new standard ktp should do the same?</pre>
</blockquote>
<p>On June 25th, 2012, 11:55 a.m., <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It dynamically adds/removes entries in the context menu based on the available support for these actions.
On this I have to agree with Alex. Disabling the menu items improves feature discoverability and it's used in other KDE apps. Can you just disable it?</pre>
</blockquote>
<p>On June 25th, 2012, 12:17 p.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ok for "block" I'll change to enable/disable so that keeps consistent when you click on the contacts.
I really don't think the "Re-request/Resend Authorisation" should be always there. They're only useful in a very small set of cases, and one of the main purposes of this patch was to reduce the size of the context menu. The user can expect a different menu because this contact is visibly in a different state (with the yellow warning icon instead of a presence). There's plenty of examples where menus do change, like on different filetypes in dolphin for example.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fair enough, ship it then!</pre>
<br />
<p>- Martin</p>
<br />
<p>On June 24th, 2012, 11:14 p.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated June 24, 2012, 11:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Check if contact manager supports blocking contact before adding the item.
Also only show re-request/resend authentication if it actually is a valid option.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>context-menu.cpp <span style="color: grey">(988f321)</span></li>
<li>dialogs/remove-contact-dialog.cpp <span style="color: grey">(7b5fa1f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105344/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>