<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104803/">http://git.reviewboard.kde.org/r/104803/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Lasath Fernando.</div>
<p style="color: grey;"><i>Updated June 15, 2012, 1:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Umm yeah... so this is a little embarrassing, but I kind of lost that patch. (I don't remember what branch/commit that was).
But, I just finished the GTalk plugin, which I started working on just after I submitted this review, thus it should include all of this. So, I've updated the diff. Could you guys please look over the changes so I can merge it?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm starting do make some headway on my project (despite being swamped by Uni work at the moment), so I thought I may as well review what I've done so far.
Firstly, I gave MessageProcessor a KPluginLoader. I then cleaned it up, removed unneeded #includes, gave AbstractMessageFilter a camel case header etc.
Before I started porting the three existing filters to be KPlugins, I decided I should write unit tests for them. I'm not really sure on what the conventions are for tests because, well I haven't seen any on this project. So I made a few QTests and stuck them in a directory called tests.
I've ported EscapeFilter and EmoticonFilter. I just wrote tests for UrlFilter, but haven't got to port it yet.
I also started documenting my work, in the hope that it'll make things easier to maintain. Currently, the Message class is more or less documented.
If at all possible, I'd like someone who isn't familiar with how these work internally to read it and tell me if that documentation is clear.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">THERE ARE UNIT TESTS!! :D</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e5dc102)</span></li>
<li>filters/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/emoticons/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/emoticons/emoticon-filter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/emoticons/emoticon-filter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/emoticons/ktptextui_message_filter_emoticons.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/escape/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/escape/escape-filter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/escape/escape-filter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/escape/ktptextui_message_filter_escape.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/formatting/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/formatting/format-filter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/formatting/format-filter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/formatting/ktptextui_message_filter_formatting.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(e94a432)</span></li>
<li>lib/KTp/AbstractMessageFilter <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/abstract-message-filter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/abstract-message-filter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/emoticon-filter.cpp <span style="color: grey">(396c8c5)</span></li>
<li>lib/escape-filter.cpp <span style="color: grey">(fd5cc37)</span></li>
<li>lib/filters.h <span style="color: grey">(2aed5bd)</span></li>
<li>lib/ktptxtui_message_filter.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/message-processor.h <span style="color: grey">(d6228b5)</span></li>
<li>lib/message-processor.cpp <span style="color: grey">(a9b409e)</span></li>
<li>lib/message.h <span style="color: grey">(c9d4340)</span></li>
<li>lib/message.cpp <span style="color: grey">(ae947d2)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/message-processor-basic-tests.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/message-processor-basic-tests.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/sync-processor.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/sync-processor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104803/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>