<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104803/">http://git.reviewboard.kde.org/r/104803/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 1st, 2012, 2:57 p.m., <b>Daniele Elmo Domenichelli</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104803/diff/1/?file=59838#file59838line11" style="color: black; font-weight: bold; text-decoration: underline;">filters/emoticons/ktptextui_message_filter_emoticons.desktop</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">11</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">X-KDE-PluginInfo-Version=0.3</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why 0.3?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To keep up with KTp. I'll ask on mailing list for what to do about this.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 1st, 2012, 2:57 p.m., <b>Daniele Elmo Domenichelli</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104803/diff/1/?file=59845#file59845line25" style="color: black; font-weight: bold; text-decoration: underline;">lib/abstract-message-filter.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">25</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">class</span> <span class="n">KDE_TELEPATHY_CHAT_EXPORT</span> <span class="n">AbstractMessageFilter</span> <span class="o">:</span> <span class="n">public</span> <span class="n">QObject</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Reminder for later: AbstractMessageFilter should have a translatable description if we want an UI to enable and disable plugins....</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">noted.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 1st, 2012, 2:57 p.m., <b>Daniele Elmo Domenichelli</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I didn't have a deep look at your code, but I think that the tests could be failing later if the user disables some of the plugins...</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">True. I was considering moving them to each individual plugin, but I realized I kind of wanted these to tell me if any plugins fail to load. I guess I'll have to find some way of forcing all plugins to enable when tests are running.</pre>
<br />
<p>- Lasath</p>
<br />
<p>On May 3rd, 2012, 12:02 p.m., Lasath Fernando wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Lasath Fernando.</div>
<p style="color: grey;"><i>Updated May 3, 2012, 12:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm starting do make some headway on my project (despite being swamped by Uni work at the moment), so I thought I may as well review what I've done so far.
Firstly, I gave MessageProcessor a KPluginLoader. I then cleaned it up, removed unneeded #includes, gave AbstractMessageFilter a camel case header etc.
Before I started porting the three existing filters to be KPlugins, I decided I should write unit tests for them. I'm not really sure on what the conventions are for tests because, well I haven't seen any on this project. So I made a few QTests and stuck them in a directory called tests.
I've ported EscapeFilter and EmoticonFilter. I just wrote tests for UrlFilter, but haven't got to port it yet.
I also started documenting my work, in the hope that it'll make things easier to maintain. Currently, the Message class is more or less documented.
If at all possible, I'd like someone who isn't familiar with how these work internally to read it and tell me if that documentation is clear.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">THERE ARE UNIT TESTS!! :D</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e5dc102)</span></li>
<li>filters/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/emoticons/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/emoticons/emoticon-filter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/emoticons/emoticon-filter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/emoticons/ktptextui_message_filter_emoticons.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/escape/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/escape/escape-filter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/escape/escape-filter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/escape/ktptextui_message_filter_escape.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(e94a432)</span></li>
<li>lib/KTp/AbstractMessageFilter <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/abstract-message-filter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/abstract-message-filter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/emoticon-filter.cpp <span style="color: grey">(0e37aab)</span></li>
<li>lib/escape-filter.cpp <span style="color: grey">(c366410)</span></li>
<li>lib/filters.h <span style="color: grey">(6059ea2)</span></li>
<li>lib/ktptxtui_message_filter.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/message-processor.h <span style="color: grey">(d6228b5)</span></li>
<li>lib/message-processor.cpp <span style="color: grey">(a9b409e)</span></li>
<li>lib/message.h <span style="color: grey">(c9d4340)</span></li>
<li>lib/message.cpp <span style="color: grey">(ae947d2)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/message-processor-basic-tests.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/message-processor-basic-tests.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/sync-processor.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/sync-processor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104803/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>