<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105220/">http://git.reviewboard.kde.org/r/105220/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Daniele Elmo</p>
<br />
<p>On June 11th, 2012, 12:51 p.m., George Kiagiadakis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By George Kiagiadakis.</div>
<p style="color: grey;"><i>Updated June 11, 2012, 12:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some fixes to make the rakia advanced options widget work properly...
commit 32c6caf33392bbafd0ad10e1e4d0ed45ac6645d5
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date: Mon Jun 11 13:55:44 2012 +0300
AbstractAccountParametersWidget: Reset parameters with disabled widgets to their default values when submitting changes
commit 2c2f47bdad9e55a45da2fae15e3f33c3f199caa8
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date: Mon Jun 11 13:41:33 2012 +0300
AbstractAccountParametersWidget: Remove unused variable
commit 42e919326ee0e3ecb2f0815f42bc28fb7925bc78
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date: Mon Jun 11 13:30:56 2012 +0300
AbstractAccountParametersWidget: Map the "currentText" property of QComboBox if the parameter requires a string type
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested setting/unsetting some properties and verifying with qdbus o.f.T.AccountManager ... that the stored parameters are correct (unlike before).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/KCMTelepathyAccounts/abstract-account-parameters-widget.cpp <span style="color: grey">(b61e836b77809819a0f6f24f9b9b1bfe2a3af6a6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105220/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>