<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104987/">http://git.reviewboard.kde.org/r/104987/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit f7f82812af1d1c3e9ec9c756a2a4ca21467b368b by Daniele E. Domenichelli to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On May 19th, 2012, 1:31 p.m., Daniele Elmo Domenichelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Daniele Elmo Domenichelli.</div>
<p style="color: grey;"><i>Updated May 19, 2012, 1:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Retrieve and save refresh token for X-MESSENGER-OAUTH2 authentication.
The refresh token will be used (in the future) to gain the access token when the old one is expired, so that the user can insert the password just the first time that he logs in.
The patch introduces the dependency on QJSON to parse the server reply, renames the token stored in KWallet from token to access_token, and stores the new refresh_token in kwallet. The authentication method is slightly different and requires another call to the server.
It's a bit late for 0.4, but I would like to ask for an exception, and to merge this part of the patch, so that perhaps I can add the second part (that will use the refresh token to get the new access token, and that I still need to write) in 0.4.1, as it won't introduce big changes. Sorry, but I was very busy recently...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">access_token is retrieved and correctly used to log in, refresh_token is saved.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e6b1df7d1017483c8234c739f84c2cc81b339882)</span></li>
<li>cmake/modules/FindQJSON.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>x-messenger-oauth2-auth-operation.cpp <span style="color: grey">(e4aa800faecb17d12c2524d6660eb9e871cb285f)</span></li>
<li>x-messenger-oauth2-prompt.h <span style="color: grey">(c87d6e7ea14c017cefd2db48d1e256802331a7eb)</span></li>
<li>x-messenger-oauth2-prompt.cpp <span style="color: grey">(c987ffdbde334c010a98478a28db740ae7bde049)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104987/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>