<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104987/">http://git.reviewboard.kde.org/r/104987/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 19th, 2012, 9:59 a.m., <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104987/diff/1/?file=64845#file64845line39" style="color: black; font-weight: bold; text-decoration: underline;">x-messenger-oauth2-auth-operation.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// FIXME We might want to remove this in ktp 0.5</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd suggest to keep that, it doesn't hurt and can help users updating from 0.3.x directly (Kubuntu 12.04 LTS)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, I'll replace it with "in a later version" ;)</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 19th, 2012, 9:59 a.m., <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104987/diff/1/?file=64845#file64845line89" style="color: black; font-weight: bold; text-decoration: underline;">x-messenger-oauth2-auth-operation.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void XMessengerOAuth2AuthOperation::onSASLStatusChanged(uint status, const QString &reason,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">81</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">kDebug</span><span class="p">()</span> <span class="o"><<</span> <span class="s">"Error authenticating - reason:"</span> <span class="o"><<</span> <span class="n">reason</span> <span class="o"><<</span> <span class="s">"- details:"</span> <span class="o"><<</span> <span class="n">details</span><span class="p">;</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">89</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">kDebug</span><span class="p">()</span> <span class="o"><<</span> <span class="s">"Error authenticating - reason:"</span> <span class="o"><<</span> <span class="n">reason</span> <span class="o"><<</span> <span class="s">"- details:"</span> <span class="o"><<</span> <span class="n">details</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I know this is an old code but can this possibly output user's credentials?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't think so, credential should not be in "reason" and/or in "details", if they are it is a bug upstream...</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 19th, 2012, 9:59 a.m., <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104987/diff/1/?file=64845#file64845line127" style="color: black; font-weight: bold; text-decoration: underline;">x-messenger-oauth2-auth-operation.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void XMessengerOAuth2AuthOperation::onDialogFinished(int result)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">119</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KTp</span><span class="o">::</span><span class="n">WalletInterface</span><span class="o">::</span><span class="n">setEntry</span><span class="p">(</span><span class="n">m_account</span><span class="p">,</span> <span class="n">XMessengerOAuth2TokenWalletEntry</span><span class="p">,</span> <span class="n">QLatin1String</span><span class="p">(</span><span class="n">m_dialog</span><span class="p">.</span><span class="n">data</span><span class="p">()</span><span class="o">-></span><span class="n">accessToken</span><span class="p">().</span><span class="n">toBase64</span><span class="p">()));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">127</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KTp</span><span class="o">::</span><span class="n">WalletInterface</span><span class="o">::</span><span class="n">setEntry</span><span class="p">(</span><span class="n">m_account</span><span class="p">,</span> <span class="n">XMessengerOAuth2<span class="hl">Access</span>TokenWalletEntry</span><span class="p">,</span> <span class="n">QLatin1String</span><span class="p">(</span><span class="n">m_dialog</span><span class="p">.</span><span class="n">data</span><span class="p">()</span><span class="o">-></span><span class="n">accessToken</span><span class="p">().</span><span class="n">toBase64</span><span class="p">()));</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">128</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KTp</span><span class="o">::</span><span class="n">WalletInterface</span><span class="o">::</span><span class="n">setEntry</span><span class="p">(</span><span class="n">m_account</span><span class="p">,</span> <span class="n">XMessengerOAuth2RefreshTokenWalletEntry</span><span class="p">,</span> <span class="n">QLatin1String</span><span class="p">(</span><span class="n">m_dialog</span><span class="p">.</span><span class="n">data</span><span class="p">()</span><span class="o">-></span><span class="n">accessToken</span><span class="p">().</span><span class="n">toBase64</span><span class="p">()));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just for me to understand - both tokens are the same?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">WTF! No!</pre>
<br />
<p>- Daniele Elmo</p>
<br />
<p>On May 18th, 2012, 8:56 p.m., Daniele Elmo Domenichelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Daniele Elmo Domenichelli.</div>
<p style="color: grey;"><i>Updated May 18, 2012, 8:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Retrieve and save refresh token for X-MESSENGER-OAUTH2 authentication.
The refresh token will be used (in the future) to gain the access token when the old one is expired, so that the user can insert the password just the first time that he logs in.
The patch introduces the dependency on QJSON to parse the server reply, renames the token stored in KWallet from token to access_token, and stores the new refresh_token in kwallet. The authentication method is slightly different and requires another call to the server.
It's a bit late for 0.4, but I would like to ask for an exception, and to merge this part of the patch, so that perhaps I can add the second part (that will use the refresh token to get the new access token, and that I still need to write) in 0.4.1, as it won't introduce big changes. Sorry, but I was very busy recently...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">access_token is retrieved and correctly used to log in, refresh_token is saved.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e6b1df7d1017483c8234c739f84c2cc81b339882)</span></li>
<li>cmake/modules/FindQJSON.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>x-messenger-oauth2-auth-operation.cpp <span style="color: grey">(e4aa800faecb17d12c2524d6660eb9e871cb285f)</span></li>
<li>x-messenger-oauth2-prompt.h <span style="color: grey">(c87d6e7ea14c017cefd2db48d1e256802331a7eb)</span></li>
<li>x-messenger-oauth2-prompt.cpp <span style="color: grey">(c987ffdbde334c010a98478a28db740ae7bde049)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104987/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>