<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104667/">http://git.reviewboard.kde.org/r/104667/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 29th, 2012, 10:41 a.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wait, let's think about it little bit. The code is fine, however we have controls of the list in the toolbar (or the settings menu). Now we add another set of (filter) controls into context menu. I'm not convinced this is a good idea. I think we could have an option to select what you want to display - "Show me all my offline friends and blocked too" || "Don't show offline contacts but still show blocked". Unite the filtering options and not put them all over the place. </pre>
<br />
<p>- Martin</p>
<br />
<p>On April 19th, 2012, 3:02 p.m., Dominik Cermak wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dominik Cermak.</div>
<p style="color: grey;"><i>Updated April 19, 2012, 3:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds a menuentry to contact-list where you can set which contacts should be shown:
* Show all contacts [that's how it is until now]
* Show unblocked contacts [default]
* Show blocked contacts
One annoying thing is that e.g. groups which have no contacts because of this filter still show up, together with the online contacts/total contacts count. This is true for all filters so maybe it's not such a big issue. Comments are welcome.
PS: I implemented it in the way the rest of contact-list is implemented, but should I use the same approach as in my last review (enum conversation) instead or let it this way?</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=294679">294679</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>contact-list-widget.h <span style="color: grey">(9688c0c5c68bd9c182cf2e978d977de09d07cfc6)</span></li>
<li>contact-list-widget.cpp <span style="color: grey">(0a1d434d9ec9bc3ea4eff4b241000e72c481b553)</span></li>
<li>main-widget.cpp <span style="color: grey">(b78cd3e433f6e81fc251e842053793db798e8011)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104667/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>