<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104594/">http://git.reviewboard.kde.org/r/104594/</a>
     </td>
    </tr>
   </table>
   <br />









<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/104594/diff/1/?file=56594#file56594line186" style="color: black; font-weight: bold; text-decoration: underline;">global-presence-chooser.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">GlobalPresenceChooser::GlobalPresenceChooser(QWidget *parent) :</pre></td>

  </tr>
 </tbody>



 
 




 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">186</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n">connect</span><span class="p">(</span><span class="n">m_globalPresence</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">currentPresenceChanged</span><span class="p">(</span><span class="n">KTp</span><span class="o">::</span><span class="n">Presence</span><span class="p">)),</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">onPresenceChanged</span><span class="p">(</span><span class="n">KTp</span><span class="o">::</span><span class="n">Presence</span><span class="p">)));</span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">186</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n">connect</span><span class="p">(</span><span class="n">m_globalPresence</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">currentPresenceChanged</span><span class="p">(</span><span class="n">KTp</span><span class="o">::</span><span class="n">Presence</span><span class="p">)),</span> <span class="k"><span class="hl">this</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n">SLOT</span><span class="p">(</span><span class="n">onPresenceChanged</span><span class="p">(</span><span class="n">KTp</span><span class="o">::</span><span class="n">Presence</span><span class="p">)));</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">'this' is implicit, does it really need to be specified here?</pre>
</div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/104594/diff/1/?file=56594#file56594line360" style="color: black; font-weight: bold; text-decoration: underline;">global-presence-chooser.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void GlobalPresenceChooser::repositionOverlays()</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">360</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="k">if</span> <span class="p">(</span> <span class="p">(</span><span class="n">m_globalPresence</span><span class="o">-></span><span class="n">currentPresence</span><span class="p">().</span><span class="n">type</span><span class="p">()</span> <span class="o">!=</span> <span class="n">Tp</span><span class="o">::</span><span class="n">ConnectionPresenceTypeOffline</span><span class="p">)</span> <span class="o">&&</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Shouldn't this be OR and not AND? (Presence is either Offline OR Invisible)</pre>
</div>
<br />



<p>- Rohan</p>


<br />
<p>On April 14th, 2012, 3:01 a.m., moses alexander wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By moses alexander.</div>


<p style="color: grey;"><i>Updated April 14, 2012, 3:01 a.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi

This is patch for https://bugs.kde.org/show_bug.cgi?id=295840 . I am able to disallow editing of presence message when the user is Offline or Invisible. 

Comments and suggestions will be appreciated.
</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>global-presence-chooser.cpp <span style="color: grey">(67e2b34)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104594/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>