<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104554/">http://git.reviewboard.kde.org/r/104554/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Aleix Pol Gonzalez.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tries to address a few problems the chat view has and simplifies the code (a tiny bit).
- just reduce opacity when the view is at the end. Having a scroll flickering doesn't feel good and helps reduce the stress the scrollbar adds in such a small UI when it's not needed. I set the opacity to 0.3 but maybe 0 would be better, or not. Don't know.
- the chat has two behaviors: a browse mode where the user is looking into the log and doesn't want to be distracted and the user is looking into the newer things on the chat. This patch tries to improve the detection of the current state by making it more relaxed. This way it won't happen that if you write too fast, then everything's messed up. [1]
Other than that, I tried to port the PlasmaWidgets.LineEdit -> PlasmaComponents.TextField. It's not really possible because at 4.8 we can't know when the user pressed "enter". I guess you want to release 0.4 to work on 4.8 so this is not possible, I think. Maybe it should be backported?
[1] I'm unsure why we need these both having the screen version, I'll leave it up to the maintainers to decide what to do with this.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">talked with myself for a while, once again. a lot of "asd" (and permutations) where written tonight.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml <span style="color: grey">(740cb34)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104554/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>