<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104543/">http://git.reviewboard.kde.org/r/104543/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit b6858d74504afd9a727f16c801fa574b41512f7c by Aleix Pol to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On April 11th, 2012, 1:48 a.m., Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and Martin Klapetek.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated April 11, 2012, 1:48 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wanted to implement some features to this chat UI, I found out the code looked a bit ugly and before doing anything further, I thought it would be better for you guys to review this.
Simplify the ConversationDelegate by actually using a Button and a QItemWidget, don't deal with plasma themes directly for no reason (if there was, I didn't see it).
Unify the checked state of the chat views. Now there's not the problem when you press "Esc" that the Chat disappeared but the button remained pressed.
With this I'd like to implement to just show 1 chat at the same time, I think it's very important usability-wise.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I played with it for a while talking to myself. I have it on my panel, but nobody is alive at this time...
http://fc02.deviantart.net/fs71/f/2010/239/d/f/forever_alone_by_foreveraloneplz.png
If there's any way I can test it further, please tell me.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegate.qml <span style="color: grey">(aa667b7)</span></li>
<li>plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml <span style="color: grey">(bfb6f1a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104543/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>