<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104510/">http://git.reviewboard.kde.org/r/104510/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 8th, 2012, 1:48 p.m., <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good. The //FUTURE part also sounds good.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Btw. the priority system and stacking stuff were done for the future when it would load the plugins dynamically as a real plugins. That also never happened (and doesn't look like it will).</pre>
<br />
<p>- Martin</p>
<br />
<p>On April 8th, 2012, 12:30 p.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated April 8, 2012, 12:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There's a bug in KDED code (which randomly sets you offline). It's hard to fix a bug in complex code so I've rewritten it to be a lot simpler. Right now it should be doing exactly the same thing, with exactly the same bug. (though the cause is a bit clearer, and hopefully the fix is too)
However fixing it should now be easier. It also makes the change to "non-global presence" a bit easier for 0.5
Remove "unconnected" dbus signals being emitted (they were for an idea that never really happened)
Removed the complex removing and adding things to a stack, just have a constant list (of two items) and loop through them.
Remove the priority code, as that now happens when you order the plugin list.
I'd like anyone to review, but will only ship it after Martin confirms. Ping me on IRC/GTalk if it doesn't make sense.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran it. Auto away works. Now playing works. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autoaway.cpp <span style="color: grey">(c4d282d)</span></li>
<li>telepathy-kded-module-plugin.h <span style="color: grey">(431a46b)</span></li>
<li>telepathy-kded-module-plugin.cpp <span style="color: grey">(418e96a)</span></li>
<li>telepathy-module.h <span style="color: grey">(05d8c38)</span></li>
<li>telepathy-module.cpp <span style="color: grey">(955ceec)</span></li>
<li>telepathy-mpris.cpp <span style="color: grey">(543109c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104510/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>