<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104407/">http://git.reviewboard.kde.org/r/104407/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 30th, 2012, 6:17 p.m., <b>Daniele Elmo Domenichelli</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
<p>On March 30th, 2012, 8:24 p.m., <b>Ahmed Ibrahim</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't have the rights to commit the code. So could you please commit it.</pre>
</blockquote>
<p>On March 31st, 2012, 10:24 a.m., <b>Daniele Elmo Domenichelli</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please push it in a personal clone (see http://community.kde.org/Sysadmin/GitKdeOrgManual) and ping on IRC, I will pull your commits from there an push them in the main repository.
Also remember to add to the last commit
FEATURE: <number of the bug/wish> (if it is just a bug use BUG: instead)
REVIEW: <number of this review>
Reviewed-by: Name(s) of the person(s) who reviewed the patch</pre>
</blockquote>
<p>On March 31st, 2012, 10:32 a.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">DrDanz - I don't think he can without commit access.
Just click "download diff", then patch. </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If he can't commit to a private clone then something is broken with kde git... Anyway I think he can, because hooks should not be enabled on private clones.
Otherwise push them to some other public repository (gitorious, github, ...), or send me the patch(es) using "git format-patch origin/master"
</pre>
<br />
<p>- Daniele Elmo</p>
<br />
<p>On March 30th, 2012, 4:28 p.m., Ahmed Ibrahim wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and Daniele Elmo Domenichelli.</div>
<div>By Ahmed Ibrahim.</div>
<p style="color: grey;"><i>Updated March 30, 2012, 4:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added Block/Unblock contact button to the KActionCollection of the ktp-text-ui.
Added also code that will help in displaying blocking/unblocking actions to the user in the ChatView.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Blocked a contact and found that is blocked in another IM client and had other opened tabs and the button was changing according to the user's block state </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=292402">292402</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/chat-window.h <span style="color: grey">(fd81141)</span></li>
<li>app/chat-window.cpp <span style="color: grey">(bd4fc35)</span></li>
<li>app/chatwindow.rc <span style="color: grey">(ac5a259)</span></li>
<li>app/main.cpp <span style="color: grey">(d76ce04)</span></li>
<li>lib/channel-contact-model.h <span style="color: grey">(41d5d84)</span></li>
<li>lib/channel-contact-model.cpp <span style="color: grey">(d731322)</span></li>
<li>lib/chat-widget.h <span style="color: grey">(10de317)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(0a0b5db)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104407/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>