<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104314/">http://git.reviewboard.kde.org/r/104314/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Almost perfect, just some nitpicking</pre>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td><a href="/r/104314/s/497/" style="color: black; font-weight: bold; font-size: 9pt;">ktp-nowplaying_1.png</a></td>
</tr>
<tr>
<td><a href="http://git.reviewboard.kde.org/r/104314/s/497/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/03/27/ktp-nowplaying_1_155_471_312_44.png" style="border: 1px black solid;" alt="Now playing changes"></a></td>
</tr>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Awesome!</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104314/diff/3/?file=55045#file55045line49" style="color: black; font-weight: bold; text-decoration: underline;">config/nowplaying-lineedit.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void NowPlayingLineEdit::dropEvent(QDropEvent *event)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">49</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setText</span><span class="p">(</span><span class="n">displayText</span><span class="p">().</span><span class="n">insert</span><span class="p">(</span><span class="n">cursorPosition</span><span class="p">(),</span> <span class="n">text</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When you drag and drop a tag, you clear the undo history (try ctrl+z) because you are using setText. Try using insert instead.
When drag and drop is successfully finished you should also focus the lineedit so that the user can continue writing</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104314/diff/3/?file=55047#file55047line59" style="color: black; font-weight: bold; text-decoration: underline;">config/nowplaying-listwidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void NowPlayingListWidget::setupItems()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">59</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QPixmap</span> <span class="n">iconPixmap</span> <span class="o">=</span> <span class="n">loader</span><span class="o">-></span><span class="n">loadIcon</span><span class="p">(</span><span class="n">m_itemsIcons</span><span class="p">.</span><span class="n">at</span><span class="p">(</span><span class="n">i</span><span class="p">),</span> <span class="n">KIconLoader</span><span class="o">::</span><span class="n">Small</span><span class="p">);</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">60</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">61</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QListWidgetItem</span> <span class="o">*</span><span class="n">newItem</span> <span class="o">=</span> <span class="k">new</span> <span class="n">QListWidgetItem</span><span class="p">(</span><span class="n">QIcon</span><span class="p">(</span><span class="n">iconPixmap</span><span class="p">),</span> <span class="n">tagName</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think that you can use just KIcon(m_itemsIcons.at(i)) here</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104314/diff/3/?file=55049#file55049line58" style="color: black; font-weight: bold; text-decoration: underline;">config/telepathy-kded-config.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">58</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ui</span><span class="o">-></span><span class="n">m_tagListWidget</span><span class="o">-></span><span class="n">setMaximumWidth</span><span class="p">((</span><span class="n">ui</span><span class="o">-></span><span class="n">m_tagListWidget</span><span class="o">-></span><span class="n">sizeHintForColumn</span><span class="p">(</span><span class="mi">0</span><span class="p">)</span> <span class="o">+</span> <span class="mi">24</span><span class="p">)</span> <span class="o">*</span> <span class="n">m_tagNames</span><span class="p">.</span><span class="n">size</span><span class="p">());</span> <span class="c1">//+24: icons size</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What happens if in some language a tag is a lot longer than the others? (I'll tell you... you will get a lot of white space) :D
Is there a better way to set the width?</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix these and it is perfect for me :D</pre>
<p>- Daniele Elmo</p>
<br />
<p>On March 27th, 2012, 8:49 p.m., Othmane Moustaouda wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Othmane Moustaouda.</div>
<p style="color: grey;"><i>Updated March 27, 2012, 8:49 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Enabled the possibility for the user to set his custom 'Now listening' presence string</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=282944">282944</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>config/CMakeLists.txt <span style="color: grey">(bd0b3f8dd89352d3b1f5e438f56123c508574ab4)</span></li>
<li>config/nowplaying-lineedit.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>config/nowplaying-lineedit.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>config/nowplaying-listwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>config/nowplaying-listwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>config/telepathy-kded-config.h <span style="color: grey">(670c513df6b0cf7e69529f980a7f809b3f3d45a0)</span></li>
<li>config/telepathy-kded-config.cpp <span style="color: grey">(1fb515f56500407b7b221d1d5310237f8d94ca7f)</span></li>
<li>config/telepathy-kded-config.ui <span style="color: grey">(0d616c5503b22f37c0ae4d5a94411d0f97b25d38)</span></li>
<li>telepathy-mpris.h <span style="color: grey">(d909863e68d0fdc7a6eb4ebb972d975ba224b6ef)</span></li>
<li>telepathy-mpris.cpp <span style="color: grey">(8dae701a203f6c5ba43a622ce7125615b4392b63)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104314/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104314/s/497/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/03/27/ktp-nowplaying_1_400x100.png" style="border: 1px black solid;" alt="Now playing changes" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>