<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104360/">http://git.reviewboard.kde.org/r/104360/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 2529a7b1514a2e935d45e0ca04369d6dfe7ee957 by David Edmundson to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On March 22nd, 2012, 4:03 a.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated March 22, 2012, 4:03 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix typo in Q_FLAGS
THE RAGE REVIEW.
This bug took me all of Tuesday night to work out.
Without it the flags can't work in QML, as the correct one isn't exposed.
Lesson for everyone:
Q_FLAGS doesn't actually check you've given it a valid flag.
Also added an presenceIcon role to the model (for the contact list applet). I don't really want to add more roles, but there was no other way sensible I could think to get the icon in QML. (this is two commits in my code, just post-review being stupid uploaded them both)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Models/accounts-filter-model.h <span style="color: grey">(36f8288b0edcbd4f809b860cf54ab19dfe5ffddf)</span></li>
<li>KTp/Models/accounts-model.h <span style="color: grey">(c86d8cfafad1e956f98f9111b54e8cb923926c98)</span></li>
<li>KTp/Models/accounts-model.cpp <span style="color: grey">(13aaa4cb1e9f9a49ee40191163809795a96fc611)</span></li>
<li>KTp/Models/contact-model-item.cpp <span style="color: grey">(50145688be749d0bbb83d814ce99f4f02ec387a8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104360/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>