<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104173/">http://git.reviewboard.kde.org/r/104173/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dominik Cermak.</div>
<p style="color: grey;"><i>Updated March 12, 2012, 7:14 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some fixes for issues I had nightmares about tonight :)
1) use handle + account as the key for the configuration file (so adding a room already in your favorites to another account won't overwrite the first one)
2) apply the filter manually after populating the combobox (because currentIndexChanged isn't emitted in this case)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now you can maintain a list of your favorite chatrooms.
These are saved in the general ktelepathyrc to use them for autoconnection (not available yet, will work on it).
To not clutter the dialog too much I introduced tabs.
I'm wondering whether it would make sense to merge those two models (RoomsModel and FavoriteRoomsModel) into one (with FavoriteRoomsModel as the base for the new one).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adding and removing favorites.
After closing and reopening contact-list the favorites are still there.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=291711">291711</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dialogs/join-chat-room-dialog.h <span style="color: grey">(b5f7c6773f6a73f5653995a559bfab39b085e089)</span></li>
<li>dialogs/join-chat-room-dialog.cpp <span style="color: grey">(06d0a3ae0d9cbfcb2247dd2593f9a6616613db20)</span></li>
<li>dialogs/join-chat-room-dialog.ui <span style="color: grey">(bec08058e2ffd56255b0f6c7977980226e973390)</span></li>
<li>rooms-model.h <span style="color: grey">(675ea4cbb02cef5d823b69b6e48b292d3b4b07cf)</span></li>
<li>rooms-model.cpp <span style="color: grey">(8a5cbb0b8fb0eaed8b30d3b516a574d231d7876e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104173/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104173/s/448/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/03/06/joinchatroom_favorites_400x100.png" style="border: 1px black solid;" alt="favorites tab" /></a>
<a href="http://git.reviewboard.kde.org/r/104173/s/449/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/03/06/joinchatroom_query_400x100.png" style="border: 1px black solid;" alt="query tab" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>