<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104069/">http://git.reviewboard.kde.org/r/104069/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 24th, 2012, 9:41 p.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Code is absolutely fine, especially the documentation.
I would like to know the reason we need this though. I'm not aware of anywhere in TpQt that gives you a Tp::ConnectionPresenceType.
I don't want people to start writing:
Ktp::Presence::iconName(myPresence.connectionPresenceType())
instead of the current:
KTp::Presence(myPresence).iconName();
Drop me a message sometime (XMPP or IRC).</pre>
</blockquote>
<p>On February 26th, 2012, 12:49 a.m., <b>Daniele Elmo Domenichelli</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The reason is to be able to create a menu very quickly and have coherence in icons and text, saving unneeded translatable strings in different components (that might be translated in a different way). It can (and actually I'm planning to do it as soon as this is merged) be used in the presence plasmoid and in the contact list.
Actually I don't think it is a problem if people uses the static method if they just need the icon, it actually saves you from allocating a KTp::Presence object </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">>Actually I don't think it is a problem if people uses the static method if they just need the icon, it actually saves you from allocating a KTp::Presence object
The cost of "allocating" a KTp::Presence object is practically 0. You always create it on the stack so no expensive memory allocation, and all the constructor does is copy one QSharedDataPointer. Not doing this is super super micro optimisation, at the cost of harder to read, inconsistent code and would result in (more of) a mixture of Tp::Presence and KTp::Presence internally.
</pre>
<br />
<p>- David</p>
<br />
<p>On February 24th, 2012, 6:01 p.m., Daniele Elmo Domenichelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Daniele Elmo Domenichelli.</div>
<p style="color: grey;"><i>Updated Feb. 24, 2012, 6:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add static methods to retrieve icon, iconName and displaystring from a Tp::ConnectionPresenceType to KTp presence and use them internally</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built, installed, and run components using them.
Everything seems ok.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/presence.h <span style="color: grey">(d116530c318586ef290f7193c9f1956f4e47b77d)</span></li>
<li>KTp/presence.cpp <span style="color: grey">(35bc0dc6088b875bf719a22f45938184b1f96bb2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104069/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>