<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103628/">http://git.reviewboard.kde.org/r/103628/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Daniele Elmo Domenichelli.</div>
<p style="color: grey;"><i>Updated Feb. 23, 2012, 7:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed all the interface stuff, now the behaviour is the same (plugins generate the default value that is replaced if display name contains the old one), but nothing is displayed to the user and the "and the display name is no longer editable.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Let plugins generate a "default" display name</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch lets each plugin generate a "default" display name, based on the parameters set.
- Default name is used if display name is empty or if it is the previous default name.
- If the current display name _contains_ the old default display name, only the default part is replaced. For example, if old default name is foo@bar.com and the display name is Foo <foo@bar.com> when the user changes something and the new default display name is foo@buz.com, the new display name becomes Foo <foo@buz.com> (This happens realtime while the user is typing)
- Otherwise the user set display name is just left unchanged.
Also all the plugins were updated. For accounts without a specific plugin, the display name is set automatically using the "account" parameter if it exists. If it does not exist the user will have to add it manually, but this doesn't seem a big issue to me...
Branch here: http://quickgit.kde.org/?p=clones%2Ftelepathy-accounts-kcm%2Fddomenichelli%2Ftelepathy-accounts-kcm.git&a=shortlog&h=refs/heads/displayname
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Created an account and modified the display name.
Edited an account and modified the display name.
Created salut account and edited using the dialog.
Edited salut account.
Tested most of the plugins.
More random tests.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=284930">284930</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/butterfly/main-options-widget.h <span style="color: grey">(19a44c818544aa747718505b4e3db158cda79f4b)</span></li>
<li>plugins/butterfly/main-options-widget.cpp <span style="color: grey">(7e4800717673b6ee7d549bae7afbf3126e0a28d4)</span></li>
<li>plugins/gabble/main-options-widget-facebook.h <span style="color: grey">(abeacc5c5b9a387d1e68151ea835bff306e5bc96)</span></li>
<li>plugins/gabble/main-options-widget-facebook.cpp <span style="color: grey">(7e800bef0c6a1bf99bbfea84d3cb411c0ebac280)</span></li>
<li>plugins/gabble/main-options-widget-googletalk.h <span style="color: grey">(b73df1129648dedb084af2d1f8ee056d06fa6bd4)</span></li>
<li>plugins/gabble/main-options-widget-googletalk.cpp <span style="color: grey">(ed97bffb0dab256af5ab2a17ad1279094e49092b)</span></li>
<li>plugins/gabble/main-options-widget-kde-talk.h <span style="color: grey">(58673ccbd51791195e125b4e1da5ab5c0f28bd5a)</span></li>
<li>plugins/gabble/main-options-widget-kde-talk.cpp <span style="color: grey">(ad1399fb5e5dc9e08a823a85009a78e5f0958393)</span></li>
<li>plugins/gabble/main-options-widget-msn.h <span style="color: grey">(6d70cbeb171c7c10161e54a932bc1c499ea8d345)</span></li>
<li>plugins/gabble/main-options-widget-msn.cpp <span style="color: grey">(913a808810b2368850657bc4f76edfa4d7d1f681)</span></li>
<li>plugins/gabble/main-options-widget.h <span style="color: grey">(46c071862a7a17b784cb17e453f023802f2c0da5)</span></li>
<li>plugins/gabble/main-options-widget.cpp <span style="color: grey">(927bb32f1e29a7e4e7dbed64ed4eb7df56e96014)</span></li>
<li>plugins/haze/aim-main-options-widget.h <span style="color: grey">(b966fb6ea06378a3e01e82ab4bd56f645036e116)</span></li>
<li>plugins/haze/aim-main-options-widget.cpp <span style="color: grey">(99068e21e0ebb0832d8d790bd2a1a1eca3addca3)</span></li>
<li>plugins/haze/icq-main-options-widget.h <span style="color: grey">(bef946cec890b649ee96e544293e30e85b2197a6)</span></li>
<li>plugins/haze/icq-main-options-widget.cpp <span style="color: grey">(b6dcbae0d419c732d9803b02410890774a683708)</span></li>
<li>plugins/haze/msn-main-options-widget.h <span style="color: grey">(8dea406a74ae64286824986f03b50e789e49f0af)</span></li>
<li>plugins/haze/msn-main-options-widget.cpp <span style="color: grey">(90d719e9c19f514040a01a311420e80eb17a926f)</span></li>
<li>plugins/haze/myspaceim-main-options-widget.h <span style="color: grey">(6c6de7f29795ee688666c7e47b2d1154f1df167a)</span></li>
<li>plugins/haze/myspaceim-main-options-widget.cpp <span style="color: grey">(94e475de6f89d5095bbcc9798b144600042e87cb)</span></li>
<li>plugins/haze/skype-main-options-widget.h <span style="color: grey">(e081243138497181336c5a9faa133973a3054490)</span></li>
<li>plugins/haze/skype-main-options-widget.cpp <span style="color: grey">(87a3448601b2f338ca9d7361424b7a926c2b14ee)</span></li>
<li>plugins/haze/yahoo-main-options-widget.h <span style="color: grey">(38ddb1a738bed52ba5b8b4f1c06de7924aef78d5)</span></li>
<li>plugins/haze/yahoo-main-options-widget.cpp <span style="color: grey">(d8bf7e132081ae1debad319a0cee6d3e1a218db0)</span></li>
<li>plugins/idle/main-options-widget.h <span style="color: grey">(bf50f3059ca4f9fb267079d71b777b666be32a40)</span></li>
<li>plugins/idle/main-options-widget.cpp <span style="color: grey">(f8aeb4b7bb777cc9b5973271344d1ebaac78aa52)</span></li>
<li>plugins/rakia/rakia-main-options-widget.h <span style="color: grey">(bd1291b8318dbc468b005a54315a9365aaf35b0c)</span></li>
<li>plugins/rakia/rakia-main-options-widget.cpp <span style="color: grey">(ecb4ee4ef4b23869b3f73077e49a5bd3ed7f035e)</span></li>
<li>plugins/salut/salut-main-options-widget.h <span style="color: grey">(ab51e1901340ab8630ba19e50b49c77eeb5ecd2d)</span></li>
<li>plugins/salut/salut-main-options-widget.cpp <span style="color: grey">(ff0339a29a5d2d79fd967a3eddbd9b5fd6fb97d3)</span></li>
<li>plugins/sunshine/sunshine-main-options-widget.h <span style="color: grey">(fbb6dca508d9bf7b313c4b14dcd1c2097cc772d5)</span></li>
<li>plugins/sunshine/sunshine-main-options-widget.cpp <span style="color: grey">(f6beaec2f60535abf00f3c86b562a547173477ab)</span></li>
<li>src/KCMTelepathyAccounts/abstract-account-parameters-widget.h <span style="color: grey">(0c6cd95db610b7cebebe3e06ca15b446fd7d024d)</span></li>
<li>src/KCMTelepathyAccounts/abstract-account-parameters-widget.cpp <span style="color: grey">(b61e836b77809819a0f6f24f9b9b1bfe2a3af6a6)</span></li>
<li>src/KCMTelepathyAccounts/account-edit-widget.h <span style="color: grey">(5db8119dfae2a31e51fca60daf40b6b083359f6f)</span></li>
<li>src/KCMTelepathyAccounts/account-edit-widget.cpp <span style="color: grey">(312a4c913394c39e1b131994fbc0a8d02b84d5df)</span></li>
<li>src/add-account-assistant.cpp <span style="color: grey">(52dd6f9493ac3db2930cbd419249afc823045230)</span></li>
<li>src/edit-account-dialog.cpp <span style="color: grey">(37cb28faacbf63160eaa116924d015d5e59ed1ee)</span></li>
<li>src/salut-details-dialog.h <span style="color: grey">(804d61b903bdf8c0946b1960aedac5b63b5b1b97)</span></li>
<li>src/salut-details-dialog.cpp <span style="color: grey">(f95826dcaa7b1fda96a695bd5f23ba9a3d4ffa63)</span></li>
<li>src/salut-enabler.h <span style="color: grey">(7d4d640d19509024b9da269cb061ba43d2896dd9)</span></li>
<li>src/salut-enabler.cpp <span style="color: grey">(b16e57f27a736404b7f9afa11439f01e36eab484)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103628/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>