<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103992/">http://git.reviewboard.kde.org/r/103992/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Perfect!</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103992/diff/1/?file=49517#file49517line44" style="color: black; font-weight: bold; text-decoration: underline;">plasmoid/declarative-plugin/messages-model.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ContinuingRole</span> <span class="c1">//FIXME: Come up with a better name for this</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If this is the role marking the continuing message, I'd suggest "ContinuingMessageRole"</pre>
</div>
<br />
<p>- Martin</p>
<br />
<p>On February 15th, 2012, 3:29 a.m., Lasath Fernando wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Lasath Fernando.</div>
<p style="color: grey;"><i>Updated Feb. 15, 2012, 3:29 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, I did quite a few little things, that I may as well get reviewed before I push.
I made the delegate of the chatArea a Loader, which then picks different Components based on messageType.
I created 3 such components
- IncomingDelegate
- OutgoingDelegate - I made these two separate because I wanted to make things that the other person said stand out, so I wanted to make messages sent by you a more subtle color. Unfortunately I couldn't find a Plasma::Theme color that did quite that, so I'm probably going to make it an option to override the color.
- ActionDelegate - so now the plasmoid supports action messages. i.e. the '/me did something' style messages.
I made it group sequential messages together.
I also made it a QT::Tool window to stop it from appearing in the taskbar</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=293485">293485</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=293519">293519</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=293984">293984</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmoid/declarative-plugin/messages-model.h <span style="color: grey">(eeeae20)</span></li>
<li>plasmoid/declarative-plugin/messages-model.cpp <span style="color: grey">(0070c83)</span></li>
<li>plasmoid/declarative-plugin/qml-plugins.cpp <span style="color: grey">(b570055)</span></li>
<li>plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ActionDelegate.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml <span style="color: grey">(783e127)</span></li>
<li>plasmoid/org.kde.ktp-chatplasmoid/contents/ui/IncomingDelegate.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoid/org.kde.ktp-chatplasmoid/contents/ui/OutgoingDelegate.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoid/org.kde.ktp-chatplasmoid/contents/ui/TextDelegate.qml <span style="color: grey">(db95451)</span></li>
<li>plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml <span style="color: grey">(0ca90cd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103992/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>