<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103848/">http://git.reviewboard.kde.org/r/103848/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me now, but I'll leave the final "ship it" to David...</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103848/diff/2/?file=48646#file48646line51" style="color: black; font-weight: bold; text-decoration: underline;">lib/message-processor.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">MessageProcessor::MessageProcessor()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">51</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_filters</span> <span class="o"><<</span> <span class="k">new</span> <span class="n">UrlFilter</span><span class="p">(</span><span class="k">this</span><span class="p">)</span> <span class="o"><<</span> <span class="k">new</span> <span class="n">EmoticonFilter</span><span class="p">(</span><span class="k">this</span><span class="p">)</span> <span class="o"><<</span> <span class="k">new</span> <span class="n">ImageFilter</span><span class="p">(</span><span class="k">this</span><span class="p">)</span> <span class="o"><<</span> <span class="k">new</span> <span class="n">EscapeFilter</span><span class="p">(</span><span class="k">this</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not sure if this makes a big difference, but before the "Escape filter" was the first executed, now it is the last</pre>
</div>
<br />
<p>- Daniele Elmo</p>
<br />
<p>On February 3rd, 2012, 12:37 p.m., Lasath Fernando wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Lasath Fernando.</div>
<p style="color: grey;"><i>Updated Feb. 3, 2012, 12:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Create an extensible framework for dealing with incomming messages in text-ui. This patch implements a MessageProcessor and 3 MessageFilters: Url and emoticon parsers, as well as an image embedding plugin (for funsizes :).
Eventually these will be turned into actual plugins that are loaded at runtime rather than being hardcoded. But for now, they just make David's code cleaner.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Spammed meme images at david. He seemed to be happy and replied with lots of smiley faces.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/CMakeLists.txt <span style="color: grey">(31dadd2)</span></li>
<li>lib/adium-theme-message-info.cpp <span style="color: grey">(c5e0dfc)</span></li>
<li>lib/adium-theme-view.h <span style="color: grey">(be90d65)</span></li>
<li>lib/adium-theme-view.cpp <span style="color: grey">(a0e7ac1)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(75acef0)</span></li>
<li>lib/emoticon-filter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/escape-filter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/filters.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/image-filter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/message-processor.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/message-processor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/message.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/message.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/url-filter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103848/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>