<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103702/">http://git.reviewboard.kde.org/r/103702/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Awesome, ship it!
Presumably the contact-list, contact-applet and send-file all need updating. Could you have patches for those pushed soon after you push this (otherwise you break trunk, and people complain on IRC. Even more so now we're in extragear)
</pre>
<br />
<p>- David</p>
<br />
<p>On February 2nd, 2012, 9:32 p.m., Daniele Elmo Domenichelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Daniele Elmo Domenichelli.</div>
<p style="color: grey;"><i>Updated Feb. 2, 2012, 9:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a class ContactGridWidget to the common module.
The class is basically the widget used in ktp-send-file for displaying the contacts (grid view + filter bar)
I had to add a new directory "Widgets" and a new library, because the class depends both on the "common" and the "models" modules.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Succesfully used in the unreleased telepathy kipi plugin</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/CMakeLists.txt <span style="color: grey">(f17ff8c3bb54408d3bfaf7773bae0e736836b9b2)</span></li>
<li>KTp/Models/CMakeLists.txt <span style="color: grey">(ce628732c3b82a02803837dd8a720b5f11281945)</span></li>
<li>KTp/Models/accounts-filter-model.h <span style="color: grey">(36f8288b0edcbd4f809b860cf54ab19dfe5ffddf)</span></li>
<li>KTp/Models/accounts-filter-model.cpp <span style="color: grey">(859c6735ee2f70ea1ba5b3ace1e4d0e788b10c13)</span></li>
<li>KTp/Models/accounts-model.h <span style="color: grey">(c86d8cfafad1e956f98f9111b54e8cb923926c98)</span></li>
<li>KTp/Models/accounts-model.cpp <span style="color: grey">(13aaa4cb1e9f9a49ee40191163809795a96fc611)</span></li>
<li>KTp/Models/contact-model-item.h <span style="color: grey">(2bb845c90a0c5ce7d494758bed01b13972432313)</span></li>
<li>KTp/Models/flat-model-proxy.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Models/flat-model-proxy.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Widgets/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Widgets/contact-grid-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Widgets/contact-grid-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103702/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>